Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: comment out the code which blocks diagnostic for top level files #45989

Closed
wants to merge 1 commit into from
Closed

test: comment out the code which blocks diagnostic for top level files #45989

wants to merge 1 commit into from

Conversation

vivek378521
Copy link

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@vivek378521 vivek378521 mentioned this pull request Dec 27, 2022
Closed
@MoLow
Copy link
Member

MoLow commented Dec 27, 2022

@vivek378521
please see the discussion on the issue: #45911,
there are some top-level diagnostics that need to be omitted, and some that don't need. this fix will introduce another issue where each file will include the summary that should only be included in the entire run:

# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0

additionally - we generally remove unused code instead of commenting it out

@MoLow
Copy link
Member

MoLow commented Feb 18, 2023

closing this PR as #46441 already resolved this issue

@MoLow MoLow closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vivek378521 @nodejs-github-bot @MoLow