Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors #46005

Closed
wants to merge 3 commits into from
Closed

[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors #46005

wants to merge 3 commits into from

Commits on Jan 23, 2023

  1. src: per-environment time origin value 

    According to https://html.spec.whatwg.org/#environment-settings-object,
the timeOrigin is a per-environment value. Worker's timeOrigin is the
time when the worker is created.

PR-URL: nodejs#43781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @fossamagna
    legendecas authored and fossamagna committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    997da3d View commit details
    Browse the repository at this point in the history

  2. src: introduce node::Realm 

    To distinguish per-context values from the node::Environment, split
those values to a new node::Realm structure and consolidate
bootstrapping methods with it.

PR-URL: nodejs#44179
Refs: nodejs#42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @legendecas @fossamagna
    legendecas authored and fossamagna committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    299e6b4 View commit details
    Browse the repository at this point in the history

  3. test_runner: avoid swallowing of asynchronously thrown errors 

    Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @fossamagna
    fossamagna committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    024450a View commit details
    Browse the repository at this point in the history