Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: rewrite loader hooks test #46016

Merged
merged 3 commits into from Dec 31, 2022
Merged

esm: rewrite loader hooks test #46016

merged 3 commits into from Dec 31, 2022

Commits on Dec 29, 2022

  1. esm: rewrite loader hooks test 

    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.
    @GeoffreyBooth
    GeoffreyBooth committed Dec 29, 2022
    Copy the full SHA
    8c07ea8 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @GeoffreyBooth @aduh95
    GeoffreyBooth and aduh95 committed Dec 30, 2022
    Copy the full SHA
    7b5e399 View commit details
    Browse the repository at this point in the history

  2. Still on main thread, so console.log still works

    @GeoffreyBooth
    GeoffreyBooth committed Dec 30, 2022
    Copy the full SHA
    0f71685 View commit details
    Browse the repository at this point in the history