doc: describe argument of Symbol.for
#46019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring
|
Review requested:
|
aymen94
approved these changes
Dec 30, 2022
lpinca
approved these changes
Dec 30, 2022
legendecas
approved these changes
Jan 3, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cd4f4b4 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring PR-URL: nodejs#46019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring PR-URL: #46019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring PR-URL: #46019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring PR-URL: #46019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring