Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools, lib: fix console intrinsic freezing #46044

Closed
wants to merge 2 commits into from
Closed

tools, lib: fix console intrinsic freezing #46044

wants to merge 2 commits into from

Commits on Jan 1, 2023

  1. tools: fix lint rule recommendation 

    The lint rule recommends destructuring console out of the
internal/console/global.js export. However, that does not
exist. The top level export is actually the console object.
    @cjihrig
    cjihrig committed Jan 1, 2023
    Copy the full SHA
    5ba2464 View commit details
    Browse the repository at this point in the history

  2. lib: fix incorrect use of console intrinsic 

    The console object was not being frozen because the intrinsic
freezing code was accessing undefined instead of the console
object.
    @cjihrig
    cjihrig committed Jan 1, 2023
    Copy the full SHA
    2350719 View commit details
    Browse the repository at this point in the history