Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use os.availableParallelism() #46052

Closed
wants to merge 1 commit into from
Closed

tools: use os.availableParallelism() #46052

wants to merge 1 commit into from

Conversation

deokjinkim
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 2, 2023
anonrig
anonrig reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for not opening a single pull request for updating all references to avalailableParallelism?

@deokjinkim
Copy link
Contributor Author

Is there a specific reason for not opening a single pull request for updating all references to avalailableParallelism?

No. I can merge to 1 PR if you want.

@anonrig
Copy link
Member

anonrig commented Jan 2, 2023

It would be a lot easier to review. Please merge them.

@deokjinkim
Copy link
Contributor Author

Okay. I'll merge releated PRs to 1 PR. Thank you for guide.

@deokjinkim
Copy link
Contributor Author

This PR is merged to #46003.

@deokjinkim deokjinkim closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deokjinkim @anonrig @nodejs-github-bot