src: Keep PipeWrap::Open function consistent with TCPWrap
#46064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
keep_the_return_value_of_open_function_consistent
branch
from
de44085
to
2f2f384
Compare
theanarkh
force-pushed
the
keep_the_return_value_of_open_function_consistent
branch
from
2f2f384
to
ab9f98a
Compare
RaisinTen
approved these changes
Jan 3, 2023
github-actions
bot
removed
the
request-ci
20 tasks
theanarkh
added
the
author ready
22 tasks
addaleax
approved these changes
Jan 6, 2023
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9e86c49 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep
PipeWrap::Openfunction consistent with TCPWrap.make -j4 test(UNIX), orvcbuild test(Windows) passes