Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add /deps/**/.github/ to .gitignore #46091

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 4, 2023

  • Ignore .github directories in the deps directory.
  • Remove deps/base64/base64/.github/.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jan 4, 2023
@lpinca lpinca force-pushed the ignore/github-directories-in-deps branch from 98dff80 to 42bcf19 Compare January 4, 2023 15:36
@@ -1,13 +0,0 @@
# `true` will close all PRs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos Will this work with v8 sync script ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it won't. The V8 sync script bypasses our .gitignore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.
@lpinca lpinca force-pushed the ignore/github-directories-in-deps branch from 42bcf19 to 049ccb7 Compare January 10, 2023 18:04
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 20359cc into nodejs:main Jan 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 20359cc

@lpinca lpinca deleted the ignore/github-directories-in-deps branch January 11, 2023 19:41
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: nodejs#46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: #46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: #46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: #46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants