crypto: return correct bit length in KeyObject's asymmetricKeyDetails #46106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
panva
force-pushed
the
fix-details-bitlenghts
branch
from
14bf4c3
to
00811fa
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
fix-details-bitlenghts
branch
from
00811fa
to
c4cee3e
Compare
jasnell
approved these changes
Jan 5, 2023
panva
added
the
author ready
addaleax
approved these changes
Jan 5, 2023
panva
added
the
commit-queue
bnoordhuis
approved these changes
Jan 6, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 021f726 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2 |
It was first released in v19.15.0 and backported to v18.x with v18.14.0 |
Thank you @panva , I don't know why it still happens then |
|
@sigalsMelio Could you please open a new issue with a description and reproduction if possible? |
|
@tniessen trying to figure out whether it's something I need to resolve with jsonwebtoken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our KeyObject details incorrectly ceil bit lengths to the nearest multiple of 8.