Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix unintended mutation #46108

Merged
merged 1 commit into from Jan 7, 2023
Merged

module: fix unintended mutation #46108

merged 1 commit into from Jan 7, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 5, 2023

@aduh95 aduh95 requested a review from RafaelGSS January 5, 2023 15:29
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 5, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48870/

@GeoffreyBooth
Copy link
Member

It’s not all that clear to me how to trigger the error that this is meant to fix; is there a minimal case you could include in the PR description so we have it for reference? Or maybe include as a unit test?

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 5, 2023 •
edited

CITGM: https://ci.nodejs.org/job/citgm-smoker/3075/
(queued, if this goes in the way of the upcoming release(s), feel free to cancel it, it's not urgent at all)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48876/

@GeoffreyBooth
Copy link
Member

CITGM: https://ci.nodejs.org/job/citgm-smoker/3075/

(queued, if this goes in the way of the upcoming release(s), feel free to cancel it, it's not urgent at all)

Is this meant as an answer to my question?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48879/

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 6, 2023

It’s not all that clear to me how to trigger the error that this is meant to fix; is there a minimal case you could include in the PR description so we have it for reference? Or maybe include as a unit test?

It's not clear to me either, however it's fixing the CITGM for esprima-v4.0.1 and watchify so I'm calling it good enough.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 693b6fb into nodejs:main Jan 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 693b6fb

@aduh95 aduh95 mentioned this pull request Jan 8, 2023
Merged
This was referenced Jan 11, 2023
Open
Open
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@aduh95 @RafaelGSS
module: fix unintended mutation
80dedc0 
Refs: nodejs#46061 (comment)
PR-URL: nodejs#46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@aduh95 @RafaelGSS
module: fix unintended mutation
54896ab 
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@aduh95 @juanarbol
module: fix unintended mutation
cf16b40 
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@aduh95 @juanarbol
module: fix unintended mutation
baf30ee 
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@arcanis arcanis arcanis approved these changes

@lpinca lpinca lpinca approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @jasnell @arcanis @lpinca @JakobJingleheimer @RafaelGSS