Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor to use validateHeaderName #46143

Merged
merged 4 commits into from Jan 17, 2023
Merged

http: refactor to use validateHeaderName #46143

merged 4 commits into from Jan 17, 2023

Commits on Jan 9, 2023

  1. http: refactor to use validateHeaderName 

    Remove duplicate implementation by using validateHeaderName.
    @deokjinkim
    deokjinkim committed Jan 9, 2023
    Copy the full SHA
    d8ab874 View commit details
    Browse the repository at this point in the history

  2. add label parameter to validateHeaderName 

    To customize error message, add label parameter
    @deokjinkim
    deokjinkim committed Jan 9, 2023
    Copy the full SHA
    a23f8f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. use || instead of default parameter

    @deokjinkim
    deokjinkim committed Jan 10, 2023
    Copy the full SHA
    b1681f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. describe default value of label as string 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @deokjinkim @mscdex
    deokjinkim and mscdex committed Jan 11, 2023
    Copy the full SHA
    2546701 View commit details
    Browse the repository at this point in the history