Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: mark importAssertions as required #46164

Merged
merged 4 commits into from Jan 12, 2023
Merged

esm: mark importAssertions as required #46164

merged 4 commits into from Jan 12, 2023

Commits on Jan 10, 2023

  1. esm: mark importAssertions as required 

    We already always specify a value, and failing to do so would likely be
a bug.
    @aduh95
    aduh95 committed Jan 10, 2023
    Copy the full SHA
    0b65872 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @aduh95
    aduh95 committed Jan 10, 2023
    Copy the full SHA
    4c14433 View commit details
    Browse the repository at this point in the history

  3. Update lib/internal/modules/esm/loader.js

    @aduh95
    aduh95 committed Jan 10, 2023
    Copy the full SHA
    8fc2ece View commit details
    Browse the repository at this point in the history

  4. Update lib/internal/modules/esm/loader.js

    @aduh95
    aduh95 committed Jan 10, 2023
    Copy the full SHA
    cd7f6e6 View commit details
    Browse the repository at this point in the history