Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: change status of event.returnvalue to legacy #46175

Merged
merged 3 commits into from Jan 19, 2023
Merged

events: change status of event.returnvalue to legacy #46175

merged 3 commits into from Jan 19, 2023

Commits on Jan 11, 2023

  1. events: change status of event.returnvalue to legacy 

    `event.returnvalue` is described as legacy in spec.
Plus, add missed '#'(private member) of defaultPrevented
in implementation.

Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
    @deokjinkim
    deokjinkim committed Jan 11, 2023
    Copy the full SHA
    c173711 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. use cancelable to determine returnValue 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Jan 17, 2023
    Copy the full SHA
    4add9b3 View commit details
    Browse the repository at this point in the history

  2. revise description of event.returnValue 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Jan 17, 2023
    Copy the full SHA
    e8262f6 View commit details
    Browse the repository at this point in the history