Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make options of readableStream.pipeTo as optional #46180

Merged

Conversation

deokjinkim
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 12, 2023
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 12, 2023
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9660579 into nodejs:main Jan 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9660579

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: nodejs#46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: #46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: #46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: #46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants