Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: implement finished() for ReadableStream and WritableStream #46205

Merged
merged 16 commits into from Jan 18, 2023
Merged

stream: implement finished() for ReadableStream and WritableStream #46205

merged 16 commits into from Jan 18, 2023

Commits on Jan 15, 2023

  1. stream: implement finished() for ReadableStream and WritableStream 

    Refs: nodejs#39316
    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    fd2fa5a View commit details
    Browse the repository at this point in the history

  2. fixup! restore tests

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    7938b4a View commit details
    Browse the repository at this point in the history

  3. fixup! add non-stream check

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    f0b8c92 View commit details
    Browse the repository at this point in the history

  4. fixup! fix return

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    3937b22 View commit details
    Browse the repository at this point in the history

  5. fixup! remove public property

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    70630b3 View commit details
    Browse the repository at this point in the history

  6. fixup! use the promise and use process.nextTick

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    2d7ea18 View commit details
    Browse the repository at this point in the history

  7. fixup! fix code style and nullish checks remove

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    b6461d9 View commit details
    Browse the repository at this point in the history

  8. fixup! remove nullish in writablestreams

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    1572862 View commit details
    Browse the repository at this point in the history

  9. fixup! add tests

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    ebeab98 View commit details
    Browse the repository at this point in the history

  10. fixup! remove util changes

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    dd5391b View commit details
    Browse the repository at this point in the history

  11. fixup! lint fix

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    9aadb9e View commit details
    Browse the repository at this point in the history

  12. fixup! rename streamClosed to closed

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    e924b60 View commit details
    Browse the repository at this point in the history

  13. fixup! remove nullish 

    Co-authored-by: Robert Nagy <ronagy@icloud.com>
    @debadree25 @ronag
    debadree25 and ronag committed Jan 15, 2023
    Copy the full SHA
    f1cbaea View commit details
    Browse the repository at this point in the history

  14. fixup! use symbols instead of kState

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    5ae4f8a View commit details
    Browse the repository at this point in the history

  15. fixup! remove brandchecks

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    4ab3a7b View commit details
    Browse the repository at this point in the history

  16. fixup! rename kIsClosed

    @debadree25
    debadree25 committed Jan 15, 2023
    Copy the full SHA
    f1ef9e4 View commit details
    Browse the repository at this point in the history