Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update postject to 1.0.0-alpha.4 #46212

Closed
wants to merge 1 commit into from
Closed

test: update postject to 1.0.0-alpha.4 #46212

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of postject to 1.0.0-alpha.4.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 14, 2023
RaisinTen
RaisinTen approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @nodejs/single-executable

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 16, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/48994/

sheplu
sheplu approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BridgeAR
BridgeAR approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the deps to test as it actually belongs to test. Otherwise LGTM

@RaisinTen RaisinTen changed the title deps: update postject to 1.0.0-alpha.4 test: update postject to 1.0.0-alpha.4 Jan 18, 2023
bnb
bnb approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RaisinTen pushed a commit that referenced this pull request Jan 19, 2023
@nodejs-github-bot @RaisinTen
test: update postject to 1.0.0-alpha.4
009416d 
PR-URL: #46212
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@RaisinTen
Copy link
Contributor

Landed in 009416d

@RaisinTen RaisinTen closed this Jan 19, 2023
@RaisinTen RaisinTen deleted the actions/tools-update-postject branch January 19, 2023 10:07
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@nodejs-github-bot @RafaelGSS
test: update postject to 1.0.0-alpha.4
c09b203 
PR-URL: #46212
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@nodejs-github-bot @juanarbol
test: update postject to 1.0.0-alpha.4
1287031 
PR-URL: #46212
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@nodejs-github-bot @juanarbol
test: update postject to 1.0.0-alpha.4
536322f 
PR-URL: #46212
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@bnb bnb bnb approved these changes

@sheplu sheplu sheplu approved these changes

@ronag ronag ronag approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aymen94 aymen94 aymen94 approved these changes

@tony-go tony-go tony-go approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@nodejs-github-bot @RaisinTen @mcollina @bnb @sheplu @ronag @joyeecheung @BridgeAR @aymen94 @tony-go