Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: let http2 streams end after session close" #46249

Closed
wants to merge 4 commits into from
Closed

Revert "src: let http2 streams end after session close" #46249

wants to merge 4 commits into from

Conversation

santigimeno
Copy link
Member

This reverts commit dee882e. Moved the test that demonstrated what this commit was fixing to the known_issues folder.

Fixes: #46234

@santigimeno
Revert "src: let http2 streams end after session close"
3619cb3 
This reverts commit dee882e.
Moved the test that demonstrated what this commit was fixing to the
`known_issues` folder.

Fixes: nodejs#46234
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jan 18, 2023
@santigimeno santigimeno mentioned this pull request Jan 18, 2023
Closed
@santigimeno
Copy link
Member Author

Once this is merged, should we reopen #42713?

@ronag
Copy link
Member

ronag commented Jan 18, 2023

Would be nice with a regression test if possible.

@santigimeno
Copy link
Member Author

Would be nice with a regression test if possible.

I moved the original test to the known_issues folder. Is that what you're asking?

mcollina
mcollina approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@nodejs/releasers this should be backported to v19.x, v18.x, and v16.x.

@mcollina mcollina added v16.x lts-watch-v18.x PRs that may need to be released in v18.x. labels Jan 18, 2023
@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS
Copy link
Member

I requested the fast-track to include it in the next v19.x release (planning to create the proposal between Thursday and Friday).

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49097/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49108/

@mcollina
Copy link
Member

The tests keep failing.

This was referenced Jan 21, 2023
Open
Open
Open
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4126652112

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Feb 8, 2023
@mcollina
Copy link
Member

mcollina commented Feb 9, 2023

yes, this can land.

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49608/

@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Open
32 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49690/

@Trott
Copy link
Member

Trott commented Feb 18, 2023

@santigimeno Can you run make lint-js-fix to add the comma in the test now required by linting rules and then push up a fixup commit? I tried to do it for you to save you the annoyance, but I don't have permission to force push to your branch.

@Trott Trott mentioned this pull request Feb 18, 2023
Merged
@Trott
Copy link
Member

Trott commented Feb 18, 2023

@santigimeno Can you run make lint-js-fix to add the comma in the test now required by linting rules and then push up a fixup commit? I tried to do it for you to save you the annoyance, but I don't have permission to force push to your branch.

In case @santigimeno isn't around over the weekend or whatever, I've opened #46721 which preserves their authorship of the commit but adds the lint fix. Maybe head over and approve/fast-track that one?

@richardlau
Copy link
Member

richardlau commented Feb 18, 2023 •
edited

Isn't the without ssl failure still unresolved?

@github-actions github-actions bot mentioned this pull request Feb 19, 2023
Open
21 tasks
@Trott
Copy link
Member

Trott commented Feb 19, 2023

Isn't the without ssl failure still unresolved?

I think all that needs to happen for that is to change common.skip to assert.fail in the test and leave a comment that when the issue is fixed and it's moved out of known_issues, it needs to be changed back.

I'll leave a suggestion.

@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Feb 19, 2023
@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
24 tasks
@santigimeno
Copy link
Member Author

This can be closed now as #46721 landed.

@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@mcollina mcollina mcollina approved these changes

@fhinkel fhinkel fhinkel approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ronag ronag ronag approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 18.13 HTTP/2 live lock