Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v19.x backport] http: res set headers #46272

Closed
wants to merge 2 commits into from
Closed

[v19.x backport] http: res set headers #46272

wants to merge 2 commits into from

Conversation

marco-ippolito
Copy link
Member

PR-URL: #46109
@RafaelGSS

@marco-ippolito
http: res.setHeaders first implementation
35bdc6c 
PR-URL: nodejs#46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito
http: backport set.headers 19.x
4002ade
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. v19.x labels Jan 19, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49096/

This was referenced Jan 21, 2023
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49150/

mcollina
mcollina approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Open
12 tasks
@marco-ippolito marco-ippolito mentioned this pull request Jan 25, 2023
Merged
@ruyadorno
Copy link
Member

This looks like a semver-minor change to me. Does that make sense @marco-ippolito @RafaelGSS ?

@ruyadorno ruyadorno added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 31, 2023
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
@marco-ippolito @ruyadorno
http: res.setHeaders first implementation
1ec6270 
Backport-PR-URL: #46272
PR-URL: #46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno
Copy link
Member

Landed in 1ec6270

@ruyadorno ruyadorno closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marco-ippolito @nodejs-github-bot @ruyadorno @mcollina @RafaelGSS