Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include webstreams in finished() and Duplex.from() parameters #46312

Merged
merged 4 commits into from Jan 31, 2023
Merged

doc: include webstreams in finished() and Duplex.from() parameters #46312

merged 4 commits into from Jan 31, 2023

Conversation

debadree25
Copy link
Member

Refs: #46190
Refs: #46205

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 23, 2023
aduh95
aduh95 reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it also include history entries (in the YAML comments) to document when the support was added?

@debadree25
Copy link
Member Author

Shouldn't it also include history entries (in the YAML comments) to document when the support was added?

What should the version be 19.5.0? #46286

@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2023

This should be v19.5.0 on main, but would need to be backported as REPLACEME on v18.x-staging along with the two PRs it refs.

@aduh95 aduh95 added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jan 23, 2023
@debadree25
Copy link
Member Author

Updated version info @aduh95

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Jan 23, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2023

Marking this as blocked until v19.5.0 is released.

@aduh95 aduh95 mentioned this pull request Jan 23, 2023
Closed
@debadree25
Copy link
Member Author

I think this would be unblocked now?

@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 31, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jan 31, 2023

You’re right :) can you please rebase to fix the failing linter test?

@debadree25 debadree25 force-pushed the ft/doc-update-finished-duplex-webstreams branch from b0a23c8 to 4dadf3b Compare January 31, 2023 16:58
@debadree25
Copy link
Member Author

You’re right :) can you please rebase to fix the failing linter test?

Done!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 145ed32 into nodejs:main Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 145ed32

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@debadree25 @ruyadorno
doc: include webstreams in finished() and Duplex.from() parameters
996bac0 
PR-URL: #46312
Refs: #46190
Refs: #46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
doc: include webstreams in finished() and Duplex.from() parameters
8ae52bf 
PR-URL: nodejs#46312
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
doc: include webstreams in finished() and Duplex.from() parameters
edaee13 
PR-URL: nodejs#46312
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
doc: include webstreams in finished() and Duplex.from() parameters
7eb38e1 
PR-URL: nodejs#46312
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25 added a commit to debadree25/node that referenced this pull request May 23, 2023
@debadree25
doc: include webstreams in finished() and Duplex.from() parameters
631afeb 
PR-URL: nodejs#46312
Refs: nodejs#46190
Refs: nodejs#46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25 @danielleadams
doc: include webstreams in finished() and Duplex.from() parameters
402c1a3 
PR-URL: #46312
Backport-PR-URL: #46314
Refs: #46190
Refs: #46205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@debadree25 @aduh95 @nodejs-github-bot