Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: deprecate napi_module_register based registration #46319

Closed
wants to merge 8 commits into from
Closed

node-api: deprecate napi_module_register based registration #46319

wants to merge 8 commits into from

Commits on Mar 10, 2023

  1. node-api: deprecate napi_module_register

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2a942d4 View commit details
    Browse the repository at this point in the history

  2. minimize changes to node_api.h

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1b072ea View commit details
    Browse the repository at this point in the history

  3. restore original change + NAPI_MODULE_X

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3981075 View commit details
    Browse the repository at this point in the history

  4. restore test_null_init test

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7e53683 View commit details
    Browse the repository at this point in the history

  5. Address PR feedback

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d0af42d View commit details
    Browse the repository at this point in the history

  6. format test_linked_binding.cc

    @vmoroz
    vmoroz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6e19806 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Format node_api.h

    @vmoroz
    vmoroz committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    16121e3 View commit details
    Browse the repository at this point in the history

  2. attempt to fix compilation on Linux

    @vmoroz
    vmoroz committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    9668188 View commit details
    Browse the repository at this point in the history