Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.x backport] http: res setheaders #46365

Closed
wants to merge 2 commits into from
Closed

[18.x backport] http: res setheaders #46365

wants to merge 2 commits into from

Conversation

marco-ippolito
Copy link
Member

PR-URL: #46109
As requested by @juanarbol #46109 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jan 26, 2023
@richardlau richardlau mentioned this pull request Jan 26, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49221/

@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49244/

@marco-ippolito
http: res.setHeaders first implementation
bcef834 
PR-URL: nodejs#46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito
http: res.setHeader 18.x backport
e835966
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49960/

@juanarbol

This comment was marked as off-topic.

Sign in to view
This was referenced Feb 25, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50046/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50050/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50060/

@marco-ippolito marco-ippolito removed the needs-ci PRs that need a full CI run. label Feb 27, 2023
This was referenced Feb 28, 2023
Open
Open
juanarbol
juanarbol approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 1, 2023
@marco-ippolito @juanarbol
http: res.setHeaders first implementation
ba71900 
PR-URL: nodejs#46109
Backport-PR-URL: nodejs#46365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol
Copy link
Member

Landed in ba71900

@juanarbol juanarbol closed this Mar 1, 2023
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Open
15 tasks
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@marco-ippolito @juanarbol
http: res.setHeaders first implementation
5019b54 
PR-URL: #46109
Backport-PR-URL: #46365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marco-ippolito @nodejs-github-bot @juanarbol @ShogunPanda