doc: update threat model based on discussions #46373
Closed
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@RafaelGSS, @mcollina, @jasnell how does this look to you? |
mhdawson
force-pushed
the
tweak-threat-model
branch
from
7235f14
to
54159df
Compare
panva
changed the title
anonrig
approved these changes
Jan 27, 2023
bnoordhuis
reviewed
Jan 27, 2023
Comment on lines
+194
to
+197
| * If Node.js is asked to connect to a remote site and return an | ||
| artifact, it is not considered a vulnerability if the size of | ||
| that artifact is large enough to impact performance and or | ||
| cause the runtime to run out of resources. |
There was a problem hiding this comment.
Is this actually true? Say I host a malicious server that triggers a hash table collision denial-of-service in node's http client - that's considered a vulnerability, right?
There was a problem hiding this comment.
@bnoordhuis I think your example is different in that it does not relate to the size of the artifact returned.
mhdawson
added a commit
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46373 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
Landed in 088e470 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46373 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46373 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson mdawson@devrus.com