Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add trailing commas in test/js-native-api #46385

Merged
merged 1 commit into from Feb 3, 2023
Merged

test: add trailing commas in test/js-native-api #46385

merged 1 commit into from Feb 3, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 27, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 27, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 29, 2023
@aduh95
test: add trailing commas in test/js-native-api
7079158 
PR-URL: nodejs#46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2023

Landed in 7079158

@aduh95 aduh95 merged commit 7079158 into nodejs:main Feb 3, 2023
@aduh95 aduh95 deleted the native-api-dangle branch February 3, 2023 16:13
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@aduh95 @MylesBorins
test: add trailing commas in test/js-native-api
faba8d4 
PR-URL: #46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
test: add trailing commas in test/js-native-api
b0f2415 
PR-URL: #46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @jasnell @legendecas @nodejs-github-bot