stream: add suport for abort signal in finished() for webstreams #46403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
debadree25
changed the title
debadree25
force-pushed
the
ft/abort-signal-webstreams-finish
branch
from
eb31a9c
to
4312987
Compare
benjamingr
approved these changes
Jan 29, 2023
ronag
approved these changes
Jan 29, 2023
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46403 ✔ Done loading data for nodejs/node/pull/46403 ----------------------------------- PR info ------------------------------------ Title stream: add suport for abort signal in finished() for webstreams (#46403) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/abort-signal-webstreams-finish -> nodejs:main Labels needs-ci Commits 2 - stream: add suport for abort signal in finished() for webstreams - fixup! add tests Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/46403 Refs: https://github.com/nodejs/node/pull/46205 Refs: https://github.com/nodejs/node/pull/37354 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46403 Refs: https://github.com/nodejs/node/pull/46205 Refs: https://github.com/nodejs/node/pull/37354 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 29 Jan 2023 05:27:07 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46403#pullrequestreview-1274265207 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/46403#pullrequestreview-1274266823 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/46403#pullrequestreview-1274274475 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-30T11:22:45Z: https://ci.nodejs.org/job/node-test-pull-request/49247/ - Querying data for job/node-test-pull-request/49247/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD f84de0ad4c..75080830a4 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 1f708d2037 stream: dont access Object.prototype.type during TransformStream init - 75080830a4 stream: dont access Object.prototype.type during TransformStream init -------------------------------------------------------------------------------- HEAD is now at 75080830a4 stream: dont access Object.prototype.type during TransformStream init ✔ Reset to origin/main - Downloading patch for 46403 From https://github.com/nodejs/node * branch refs/pull/46403/merge -> FETCH_HEAD ✔ Fetched commits as 75080830a40d..43129876236c -------------------------------------------------------------------------------- [main 3cbb426140] stream: add suport for abort signal in finished() for webstreams Author: Debadree Chatterjee Date: Sun Jan 29 09:48:41 2023 +0530 1 file changed, 26 insertions(+), 3 deletions(-) [main 3034793ca3] fixup! add tests Author: Debadree Chatterjee Date: Sun Jan 29 10:52:07 2023 +0530 1 file changed, 90 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4077785291 |
lpinca
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in ebcc711 |
Merged
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Feb 27, 2023
Refs: nodejs#46205 PR-URL: nodejs#46403 Refs: nodejs#37354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Feb 27, 2023
Refs: nodejs#46205 PR-URL: nodejs#46403 Refs: nodejs#37354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Feb 27, 2023
Refs: nodejs#46205 PR-URL: nodejs#46403 Refs: nodejs#37354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our original PR we hadn't added support for
AbortSignalwhen using webstreams withfinished()hence added the same hereRefs: #46205
Refs: #37354