Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: allow writing files with ArrayBuffers #46490

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fs: allow writing files with ArrayBuffers #46490

wants to merge 6 commits into from

Commits on Feb 17, 2023

  1. fs: allow writing files with ArrayBuffers 

    Extended most file writing functions to accept ArrayBuffers rather
than only strings, buffers, or data views. Does not include
functions that accept arrays of dataviews, such as writev.

Fixes: nodejs#42228
    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5802e95 View commit details
    Browse the repository at this point in the history

  2. implement writev for arraybuffers, update tests and docs

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ad09466 View commit details
    Browse the repository at this point in the history

  3. update docs and tests

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d9bd41f View commit details
    Browse the repository at this point in the history

  4. minor fixes

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    7b5fe63 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. fix buffer offset in test

    @SRHerzog
    SRHerzog committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7f63710 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. allow SharedArrayBuffer as well as ArrayBuffer

    @SRHerzog
    SRHerzog committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fdad5c2 View commit details
    Browse the repository at this point in the history