Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: refactor to use validateAbortSignal #46520

Merged
merged 1 commit into from Feb 8, 2023
Merged

stream: refactor to use validateAbortSignal #46520

merged 1 commit into from Feb 8, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 6, 2023

All APIs currently accept any AbortSignal-like objects, which is what validateAbortSignal checks for. Let's use this here for consistency.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Feb 6, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49458/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit da89ab8 into nodejs:main Feb 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in da89ab8

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@aduh95 @MylesBorins
stream: refactor to use validateAbortSignal
f91260b 
PR-URL: #46520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
stream: refactor to use validateAbortSignal
17b4e9b 
PR-URL: #46520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @nodejs-github-bot @jasnell @lpinca