doc: fix test runner examples #46565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
|
@richiemccoll did you mean to mark this as a draft? |
|
@cjihrig I've marked it ready for review now. |
cjihrig
approved these changes
Feb 8, 2023
MoLow
approved these changes
Feb 8, 2023
MoLow
added
the
author ready
ShogunPanda
approved these changes
Feb 8, 2023
lpinca
approved these changes
Feb 8, 2023
MoLow
added
the
commit-queue
benjamingr
approved these changes
Feb 9, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in be49214 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46565 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
juliangruber
pushed a commit
to nodejs/node-core-test
that referenced
this pull request
Mar 16, 2023
PR-URL: nodejs/node#46565 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit be4921474671fb15f0e62adfe2f37253d07eca02)
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46565 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
beforeEachandafterEachexamples fordescribethrow errors becauset.diagnosticdoes not exist.This PR updates those two examples to use the same pattern as before and after which is to use
console.log.