nodejs · aduh95 · Feb 12, 2023 · Feb 10, 2023
diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml
@@ -78,7 +78,6 @@ overrides:
       - es-module/*.mjs
       - parallel/*.js
       - parallel/*.mjs
-      - pummel/*.js
       - sequential/*.js
       - sequential/*.mjs
     rules:

diff --git a/test/pummel/test-crypto-timing-safe-equal-benchmarks.js b/test/pummel/test-crypto-timing-safe-equal-benchmarks.js
@@ -108,7 +108,7 @@ const T_THRESHOLD = 3.892;
 const t = getTValue(crypto.timingSafeEqual);
 assert(
   Math.abs(t) < T_THRESHOLD,
-  `timingSafeEqual should not leak information from its execution time (t=${t})`
+  `timingSafeEqual should not leak information from its execution time (t=${t})`,
 );
 
 // As a coherence check to make sure the statistical tests are working, run the
@@ -118,5 +118,5 @@ const unsafeCompare = (bufA, bufB) => bufA.equals(bufB);
 const t2 = getTValue(unsafeCompare);
 assert(
   Math.abs(t2) > T_THRESHOLD,
-  `Buffer#equals should leak information from its execution time (t=${t2})`
+  `Buffer#equals should leak information from its execution time (t=${t2})`,
 );
diff --git a/test/pummel/test-dh-regr.js b/test/pummel/test-dh-regr.js
@@ -54,6 +54,6 @@ for (let i = 0; i < 2000; i++) {
     bSecret,
     'Secrets should be equal.\n' +
     `aSecret: ${aSecret.toString('base64')}\n` +
-    `bSecret: ${bSecret.toString('base64')}`
+    `bSecret: ${bSecret.toString('base64')}`,
   );
 }
diff --git a/test/pummel/test-fs-readfile-tostring-fail.js b/test/pummel/test-fs-readfile-tostring-fail.js
@@ -18,7 +18,7 @@ tmpdir.refresh();
 
 const file = path.join(tmpdir.path, 'toobig.txt');
 const stream = fs.createWriteStream(file, {
-  flags: 'a'
+  flags: 'a',
 });
 
 stream.on('error', (err) => { throw err; });
@@ -44,7 +44,7 @@ stream.on('finish', common.mustCall(function() {
         message: 'Cannot create a string longer than ' +
                  `0x${stringLengthHex} characters`,
         code: 'ERR_STRING_TOO_LONG',
-        name: 'Error'
+        name: 'Error',
       })(err);
     }
     assert.strictEqual(buf, undefined);

diff --git a/test/pummel/test-fs-watch-file.js b/test/pummel/test-fs-watch-file.js
@@ -58,7 +58,7 @@ fs.writeFileSync(filepathOne, 'hello');
 
 assert.throws(
   () => { fs.watchFile(filepathOne); },
-  { code: 'ERR_INVALID_ARG_TYPE' }
+  { code: 'ERR_INVALID_ARG_TYPE' },
 );
 
 // Does not throw.
@@ -78,7 +78,7 @@ fs.writeFileSync(filepathTwoAbs, 'howdy');
 
 assert.throws(
   () => { fs.watchFile(filepathTwo); },
-  { code: 'ERR_INVALID_ARG_TYPE' }
+  { code: 'ERR_INVALID_ARG_TYPE' },
 );
 
 { // Does not throw.

diff --git a/test/pummel/test-heapdump-dns.js b/test/pummel/test-heapdump-dns.js
@@ -14,6 +14,6 @@ validateSnapshotNodes('Node / ChannelWrap', [
       // `Node / ChannelWrap` (C++) -> `ChannelWrap` (JS)
       { node_name: 'ChannelWrap', edge_name: 'native_to_javascript' },
     ],
-    detachedness: 2
+    detachedness: 2,
   },
 ]);
diff --git a/test/pummel/test-heapdump-env.js b/test/pummel/test-heapdump-env.js
@@ -18,7 +18,7 @@ validateSnapshotNodes('Node / Environment', [{
     { node_name: 'Node / CleanupQueue', edge_name: 'cleanup_queue' },
     { node_name: 'Node / IsolateData', edge_name: 'isolate_data' },
     { node_name: 'Node / Realm', edge_name: 'principal_realm' },
-  ]
+  ],
 }]);
 
 validateSnapshotNodes('Node / CleanupQueue', [
@@ -28,14 +28,14 @@ validateSnapshotNodes('Node / CleanupQueue', [
   {
     children: [
       { node_name: 'Node / ContextifyScript' },
-    ]
+    ],
   },
 ]);
 
 validateSnapshotNodes('Node / Realm', [{
   children: [
     { node_name: 'process', edge_name: 'process_object' },
-  ]
+  ],
 }]);
 
 console.log(context);  // Make sure it's not GC'ed
diff --git a/test/pummel/test-heapdump-fs-promise.js b/test/pummel/test-heapdump-fs-promise.js
@@ -11,6 +11,6 @@ validateSnapshotNodes('Node / FSReqPromise', [
     children: [
       { node_name: 'FSReqPromise', edge_name: 'native_to_javascript' },
       { node_name: 'Float64Array', edge_name: 'stats_field_array' },
-    ]
+    ],
   },
 ]);
diff --git a/test/pummel/test-heapdump-http2.js b/test/pummel/test-heapdump-http2.js
@@ -29,7 +29,7 @@ server.listen(0, () => {
         children: [
           // current_headers and/or queue could be empty
           { node_name: 'Http2Stream', edge_name: 'native_to_javascript' },
-        ]
+        ],
       },
     ], { loose: true });
 
@@ -39,29 +39,29 @@ server.listen(0, () => {
         children: [
           { node_name: 'FileHandle', edge_name: 'native_to_javascript' },
           // current_headers could be empty
-        ]
+        ],
       },
     ], { loose: true });
     state.validateSnapshotNodes('Node / TCPSocketWrap', [
       {
         children: [
           { node_name: 'TCP', edge_name: 'native_to_javascript' },
-        ]
+        ],
       },
     ], { loose: true });
     state.validateSnapshotNodes('Node / TCPServerWrap', [
       {
         children: [
           { node_name: 'TCP', edge_name: 'native_to_javascript' },
-        ]
+        ],
       },
     ], { loose: true });
     // `Node / StreamPipe` (C++) -> StreamPipe (JS)
     state.validateSnapshotNodes('Node / StreamPipe', [
       {
         children: [
           { node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
-        ]
+        ],
       },
     ]);
     // `Node / Http2Session` (C++) -> Http2Session (JS)
@@ -71,11 +71,11 @@ server.listen(0, () => {
           { node_name: 'Http2Session', edge_name: 'native_to_javascript' },
           { node_name: 'Node / nghttp2_memory', edge_name: 'nghttp2_memory' },
           {
-            node_name: 'Node / streams', edge_name: 'streams'
+            node_name: 'Node / streams', edge_name: 'streams',
           },
           // outstanding_pings, outgoing_buffers, outgoing_storage,
           // pending_rst_streams could be empty
-        ]
+        ],
       },
     ], { loose: true });
   }));

diff --git a/test/pummel/test-heapdump-inspector.js b/test/pummel/test-heapdump-inspector.js
@@ -10,7 +10,7 @@ const inspector = require('inspector');
 const snapshotNode = {
   children: [
     { node_name: 'Node / InspectorSession', edge_name: 'session' },
-  ]
+  ],
 };
 
 // Starts with no JSBindingsConnection (or 1 if coverage enabled).
@@ -34,7 +34,7 @@ const snapshotNode = {
         (edge) => edge.name === 'callback' &&
           (edge.to.type === undefined || // embedded graph
            edge.to.type === 'closure'), // snapshot
-      ]
+      ],
     },
   ];
   if (process.env.NODE_V8_COVERAGE) {

diff --git a/test/pummel/test-heapdump-tls.js b/test/pummel/test-heapdump-tls.js
@@ -29,7 +29,7 @@ const server = net.createServer(common.mustCall((c) => {
         // `Node / TLSWrap` (C++) -> `TLSWrap` (JS)
         { node_name: 'TLSWrap', edge_name: 'native_to_javascript' },
         // pending_cleartext_input could be empty
-      ]
+      ],
     },
   ]);
 }));
diff --git a/test/pummel/test-heapdump-worker.js b/test/pummel/test-heapdump-worker.js
@@ -10,7 +10,7 @@ validateSnapshotNodes('Node / MessagePort', [
   {
     children: [
       { node_name: 'Node / MessagePortData', edge_name: 'data' },
-    ]
+    ],
   },
 ], { loose: true });
 worker.terminate();
diff --git a/test/pummel/test-heapdump-zlib.js b/test/pummel/test-heapdump-zlib.js
@@ -12,7 +12,7 @@ validateSnapshotNodes('Node / ZlibStream', [
     children: [
       { node_name: 'Zlib', edge_name: 'native_to_javascript' },
       // No entry for memory because zlib memory is initialized lazily.
-    ]
+    ],
   },
 ]);
 
@@ -22,7 +22,7 @@ gzip.write('hello world', common.mustCall(() => {
       children: [
         { node_name: 'Zlib', edge_name: 'native_to_javascript' },
         { node_name: 'Node / zlib_memory', edge_name: 'zlib_memory' },
-      ]
+      ],
     },
   ]);
 }));
diff --git a/test/pummel/test-heapsnapshot-near-heap-limit-big.js b/test/pummel/test-heapsnapshot-near-heap-limit-big.js
@@ -8,7 +8,7 @@ const fixtures = require('../common/fixtures');
 const fs = require('fs');
 const env = {
   ...process.env,
-  NODE_DEBUG_NATIVE: 'diagnostics'
+  NODE_DEBUG_NATIVE: 'diagnostics',
 };
 
 if (!common.enoughTestMem)
@@ -26,7 +26,7 @@ if (!common.enoughTestMem)
     env: {
       ...env,
       TEST_CHUNK: 2000,
-    }
+    },
   });
   const stderr = child.stderr.toString();
   console.log(stderr);

diff --git a/test/pummel/test-heapsnapshot-near-heap-limit-bounded.js b/test/pummel/test-heapsnapshot-near-heap-limit-bounded.js
@@ -16,7 +16,7 @@ const env = {
   TEST_ALLOCATION: 50000,
   TEST_CHUNK: 1000,
   TEST_CLEAN_INTERVAL: 500,
-  NODE_DEBUG_NATIVE: 'diagnostics'
+  NODE_DEBUG_NATIVE: 'diagnostics',
 };
 
 {

diff --git a/test/pummel/test-heapsnapshot-near-heap-limit-by-api.js b/test/pummel/test-heapsnapshot-near-heap-limit-by-api.js
@@ -98,7 +98,7 @@ const env = {
     env: {
       ...env,
       limit: 1,
-      limit2: 2
+      limit2: 2,
     },
   });
   console.log(child.stdout.toString());

diff --git a/test/pummel/test-heapsnapshot-near-heap-limit.js b/test/pummel/test-heapsnapshot-near-heap-limit.js
@@ -13,7 +13,7 @@ const fixtures = require('../common/fixtures');
 const fs = require('fs');
 const env = {
   ...process.env,
-  NODE_DEBUG_NATIVE: 'diagnostics'
+  NODE_DEBUG_NATIVE: 'diagnostics',
 };
 
 {

diff --git a/test/pummel/test-http-many-keep-alive-connections.js b/test/pummel/test-http-many-keep-alive-connections.js
@@ -45,8 +45,8 @@ server.listen(0, function connect() {
     port: server.address().port,
     path: '/',
     headers: {
-      'Connection': 'Keep-alive'
-    }
+      'Connection': 'Keep-alive',
+    },
   }, function(res) {
     res.on('end', function() {
       if (++responses < expected) {

diff --git a/test/pummel/test-http-upload-timeout.js b/test/pummel/test-http-upload-timeout.js
@@ -53,7 +53,7 @@ server.listen(0, function() {
       const request = http.request({
         port: server.address().port,
         method: 'POST',
-        path: '/'
+        path: '/',
       });
 
       function ping() {

diff --git a/test/pummel/test-https-large-response.js b/test/pummel/test-https-large-response.js
@@ -30,7 +30,7 @@ const https = require('https');
 
 const options = {
   key: fixtures.readKey('agent1-key.pem'),
-  cert: fixtures.readKey('agent1-cert.pem')
+  cert: fixtures.readKey('agent1-cert.pem'),
 };
 
 process.stdout.write('build body...');
@@ -46,7 +46,7 @@ const server = https.createServer(options, common.mustCall(function(req, res) {
 server.listen(0, common.mustCall(function() {
   https.get({
     port: server.address().port,
-    rejectUnauthorized: false
+    rejectUnauthorized: false,
   }, common.mustCall(function(res) {
     console.log('response!');
 

diff --git a/test/pummel/test-https-no-reader.js b/test/pummel/test-https-no-reader.js
@@ -30,7 +30,7 @@ const fixtures = require('../common/fixtures');
 
 const options = {
   key: fixtures.readKey('rsa_private.pem'),
-  cert: fixtures.readKey('rsa_cert.crt')
+  cert: fixtures.readKey('rsa_cert.crt'),
 };
 
 const buf = Buffer.allocUnsafe(1024 * 1024);
@@ -47,7 +47,7 @@ server.listen(0, function() {
   const req = https.request({
     method: 'POST',
     port: server.address().port,
-    rejectUnauthorized: false
+    rejectUnauthorized: false,
   }, function(res) {
     res.read(0);
 

diff --git a/test/pummel/test-keep-alive.js b/test/pummel/test-keep-alive.js
@@ -37,7 +37,7 @@ const body = 'hello world\n';
 const server = http.createServer((req, res) => {
   res.writeHead(200, {
     'Content-Length': body.length,
-    'Content-Type': 'text/plain'
+    'Content-Type': 'text/plain',
   });
   res.write(body);
   res.end();
@@ -108,17 +108,17 @@ process.on('exit', () => {
   assert.strictEqual(
     normalReqSec > 50,
     true,
-    `normalReqSec should be greater than 50, but got ${normalReqSec}`
+    `normalReqSec should be greater than 50, but got ${normalReqSec}`,
   );
   assert.strictEqual(
     keepAliveReqSec > 50,
     true,
-    `keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}`
+    `keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}`,
   );
   assert.strictEqual(
     normalReqSec < keepAliveReqSec,
     true,
     'normalReqSec should be less than keepAliveReqSec, ' +
-    `but ${normalReqSec} is greater than ${keepAliveReqSec}`
+    `but ${normalReqSec} is greater than ${keepAliveReqSec}`,
   );
 });
diff --git a/test/pummel/test-net-throttle.js b/test/pummel/test-net-throttle.js
@@ -46,7 +46,7 @@ const server = net.createServer((connection) => {
   assert.ok(connection.bufferSize >= 0, `bufferSize: ${connection.bufferSize}`);
   assert.ok(
     connection.writableLength <= totalLength,
-    `writableLength: ${connection.writableLength}, totalLength: ${totalLength}`
+    `writableLength: ${connection.writableLength}, totalLength: ${totalLength}`,
   );
   connection.end();
 });