Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: properly handle defining props on any value #46615

Merged
merged 4 commits into from Mar 18, 2023
Merged

vm: properly handle defining props on any value #46615

merged 4 commits into from Mar 18, 2023

Commits on Mar 9, 2023

  1. vm: properly handle defining props on any value 

    While it was supposed to fix most of the remaining issues,
nodejs#46458 missed some in strict mode.

This PR adds some additional checks. It also clarifies what we are
really checking to execute or not the `GetReturnValue`.
    @dubzzz
    dubzzz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b636069 View commit details
    Browse the repository at this point in the history

  2. Apply comments of 1st review

    @dubzzz
    dubzzz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    af0f961 View commit details
    Browse the repository at this point in the history

  3. Apply comments of 2nd review

    @dubzzz
    dubzzz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6572627 View commit details
    Browse the repository at this point in the history

  4. Apply comments of 3rd review

    @dubzzz
    dubzzz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    790fa93 View commit details
    Browse the repository at this point in the history