lib: rename internal module declaration as internal bindings #46663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
joyeecheung
approved these changes
Feb 15, 2023
VoltrexKeyva
approved these changes
Feb 15, 2023
cjihrig
approved these changes
Feb 15, 2023
legendecas
approved these changes
Feb 15, 2023
RaisinTen
approved these changes
Feb 15, 2023
aduh95
added
author ready
This is a follow-up to nodejs#45551 . Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to NODE_BINDING_CONTEXT_AWARE_INTERNAL. As these bindings are already loaded with the function internalBinding in the JS land, the term "internal binding" can be straightforward to be adopted.
okmttdhr
force-pushed
the
rename-internal-module-declaration
branch
from
30ba095
to
aea041b
Compare
lpinca
approved these changes
Feb 16, 2023
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Feb 20, 2023
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fadcee7 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
This is a follow-up to #45551 . Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to NODE_BINDING_CONTEXT_AWARE_INTERNAL. As these bindings are already loaded with the function internalBinding in the JS land, the term "internal binding" can be straightforward to be adopted. PR-URL: #46663 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
This is a follow-up to #45551 . Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to NODE_BINDING_CONTEXT_AWARE_INTERNAL. As these bindings are already loaded with the function internalBinding in the JS land, the term "internal binding" can be straightforward to be adopted. PR-URL: #46663 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
This is a follow-up to #45551 . Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to NODE_BINDING_CONTEXT_AWARE_INTERNAL. As these bindings are already loaded with the function internalBinding in the JS land, the term "internal binding" can be straightforward to be adopted. PR-URL: #46663 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #45551.
Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to
NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function
internalBindingin the JS land, the term "internal binding" can be straightforward to be adopted.