Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add trailing commas in source files #46696

Merged
merged 1 commit into from Feb 20, 2023
Merged

fs: add trailing commas in source files #46696

merged 1 commit into from Feb 20, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 17, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 17, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 17, 2023
@aduh95 aduh95 merged commit 9f19253 into nodejs:main Feb 20, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 20, 2023

Landed in 9f19253

@aduh95 aduh95 deleted the fs-dangle branch February 20, 2023 00:58
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
fs: add trailing commas in source files
4c12e6e 
PR-URL: #46696
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
fs: add trailing commas in source files
efc2409 
PR-URL: #46696
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MoLow MoLow MoLow approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @jasnell @MoLow @RaisinTen @LiviaMedeiros @nodejs-github-bot