Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix AliasedBuffer memory attribution in heap snapshots #46817

Closed
wants to merge 5 commits into from

Commits on Feb 24, 2023

  1. src: make util.h self-containted

    Before it depended on util-inl.h. Fix it by moving
    MaybeStackBuffer::AllocateSufficientStorage() into
    util-inl.h
    joyeecheung committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f8def28 View commit details
    Browse the repository at this point in the history
  2. src: move AliasedBuffer implementation to -inl.h

    Drive-by: Replace the SFINAE with a static_assert because we don't
    have (or need) an implementation for non-scalar AliasedBufferBase
    otherwise. Add forward declarations to memory_tracker.h now that
    aliased-buffer.h no longer includes util-inl.h.
    joyeecheung committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    cf1cc6a View commit details
    Browse the repository at this point in the history
  3. src: fix AliasedBuffer memory attribution in heap snapshots

    Before the AliasedBuffers were represented solely by the TypedArrays
    event though they also retain additional memory themselves.
    Make the accounting more accurate by implementing MemoryRetainer in
    AliasedBuffer.
    joyeecheung committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    1e7b444 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Configuration menu
    Copy the full SHA
    832a61d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    5cdd9e1 View commit details
    Browse the repository at this point in the history