Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve documentation for util.types.isNativeError() #46840

Merged
merged 12 commits into from Mar 18, 2023
Merged

doc: improve documentation for util.types.isNativeError() #46840

merged 12 commits into from Mar 18, 2023

Commits on Feb 25, 2023

  1. doc: improve documentation for util.types.isNativeError() 

    Makes clear what a native error is by linking the spec. Explains that
`instanceof Error` and util.types.isNativeError() are not equivalent.
Give examples for objects that are `instance of Error` but not native
errors and vice versa. Recommends checking for both if one wants to find
out if something is an error.
    @brodo
    brodo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0286b65 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    170eacf View commit details
    Browse the repository at this point in the history

  2. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    c4e75d6 View commit details
    Browse the repository at this point in the history

  3. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    1ed4fe9 View commit details
    Browse the repository at this point in the history

  4. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    4f36ecf View commit details
    Browse the repository at this point in the history

  5. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    e0315e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. doc: leave out recommendation to for error checking

    @brodo
    brodo committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    b7f6043 View commit details
    Browse the repository at this point in the history

  2. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7799e53 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Update doc/api/util.md 

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    @brodo @lpinca
    brodo and lpinca committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    46a1a98 View commit details
    Browse the repository at this point in the history

  2. Update doc/api/util.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @brodo @aduh95
    brodo and aduh95 committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    7d2ad63 View commit details
    Browse the repository at this point in the history

  3. doc(util.md): sort references in native order

    @brodo
    brodo committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c82066f View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Update doc/api/util.md 

    Co-authored-by: James M Snell <jasnell@gmail.com>
    @brodo @jasnell
    brodo and jasnell committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    146c632 View commit details
    Browse the repository at this point in the history