test: fix test file path in test-permission-deny-fs-symlink-target-write.js
#46859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Feb 27, 2023
…rite.js Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros
added
the
commit-queue-squash
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Feb 28, 2023
LiviaMedeiros
added
author ready
anonrig
approved these changes
Feb 28, 2023
|
Can we fast-track this? It isn't very pleasant at the moment. |
LiviaMedeiros
added
the
fast-track
|
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
|
Yes, fast-track would be great. For clarification: this test creates |
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46859 ✔ Done loading data for nodejs/node/pull/46859 ----------------------------------- PR info ------------------------------------ Title test: fix test file path in `test-permission-deny-fs-symlink-target-write.js` (#46859) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:test-fix-permdenysymwrite-pollution -> nodejs:main Labels test, fast-track, author ready, needs-ci, commit-queue-squash Commits 3 - test: fix file path in permission symlink test - squash: Update test/parallel/test-permission-deny-fs-symlink-target-w… - squash: fixup Committers 2 - LiviaMedeiros - GitHub PR-URL: https://github.com/nodejs/node/pull/46859 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46859 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 27 Feb 2023 10:20:16 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317516821 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317760108 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-28T15:21:19Z: https://ci.nodejs.org/job/node-test-pull-request/50106/ - Querying data for job/node-test-pull-request/50106/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4294881377 |
LiviaMedeiros
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46859 ✔ Done loading data for nodejs/node/pull/46859 ----------------------------------- PR info ------------------------------------ Title test: fix test file path in `test-permission-deny-fs-symlink-target-write.js` (#46859) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:test-fix-permdenysymwrite-pollution -> nodejs:main Labels test, fast-track, author ready, needs-ci, commit-queue-squash Commits 3 - test: fix file path in permission symlink test - squash: Update test/parallel/test-permission-deny-fs-symlink-target-w… - squash: fixup Committers 2 - LiviaMedeiros - GitHub PR-URL: https://github.com/nodejs/node/pull/46859 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46859 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 27 Feb 2023 10:20:16 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317516821 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317760108 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-28T16:44:09Z: https://ci.nodejs.org/job/node-test-pull-request/50109/ - Querying data for job/node-test-pull-request/50109/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4295652013 |
LiviaMedeiros
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4a7c3e9 |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Mar 3, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46859 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
added
backport-blocked-v16.x
backport-blocked-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test creates
filewithsome contentin current working directory. Let's move it to tmpdir.