Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: set formatUrl method as no side effect #46884

Merged
merged 1 commit into from
Mar 2, 2023
Merged

url: set formatUrl method as no side effect #46884

merged 1 commit into from
Mar 2, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 28, 2023 •
edited

formatUrl does not have any side effects.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 28, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50100/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2023
BridgeAR
BridgeAR approved these changes Feb 28, 2023
View reviewed changes
src/node_url.cc Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50112/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Open
15 tasks
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Open
15 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7bd909b into nodejs:main Mar 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7bd909b

This was referenced Mar 3, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@anonrig @targos
url: set formatUrl method as no side effect
02c907d 
PR-URL: #46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
@anonrig @targos
url: set formatUrl method as no side effect
b1747fe 
PR-URL: #46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams
Copy link
Member

blocked by #46736

@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Apr 3, 2023
anonrig added a commit to anonrig/node that referenced this pull request Jun 5, 2023
@anonrig
url: set formatUrl method as no side effect
d0abab9 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@anonrig anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
@anonrig anonrig added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Jun 5, 2023
anonrig added a commit to anonrig/node that referenced this pull request Jun 23, 2023
@anonrig
url: set formatUrl method as no side effect
5810ea9 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
anonrig added a commit to anonrig/node that referenced this pull request Jun 23, 2023
@anonrig
url: set formatUrl method as no side effect
38b4692 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
anonrig added a commit to anonrig/node that referenced this pull request Jun 26, 2023
@anonrig
url: set formatUrl method as no side effect
476dff1 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
anonrig added a commit to anonrig/node that referenced this pull request Jul 6, 2023
@anonrig
url: set formatUrl method as no side effect
6065da5 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
anonrig added a commit to anonrig/node that referenced this pull request Jul 9, 2023
@anonrig
url: set formatUrl method as no side effect
17e3fd0 
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: set formatUrl method as no side effect
aa4f485 
PR-URL: #46884
Backport-PR-URL: #48345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@anonrig @nodejs-github-bot @danielleadams @addaleax @TimothyGu @cjihrig @tniessen @BridgeAR