V18.15.0 proposal #46920
Merged
V18.15.0 proposal #46920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot
added
doc
juanarbol
force-pushed
the
v18.15.0-proposal
branch
from
1fd3ca2
to
6b8ecaa
Compare
juanarbol
added a commit
that referenced
this pull request
Mar 3, 2023
Notable Changes buffer: * add isAscii method (Yagiz Nizipli) #46046 fs: * add statfs() functions (Colin Ihrig) #46358 src,lib: * add constrainedMemory API for process (theanarkh) #46218 v8: * support gc profile (theanarkh) #46255 vm: * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
juanarbol
added
release
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
added a commit
that referenced
this pull request
Mar 3, 2023
Notable Changes: buffer: * add isAscii method (Yagiz Nizipli) #46046 fs: * add statfs() functions (Colin Ihrig) #46358 src,lib: * add constrainedMemory API for process (theanarkh) #46218 v8: * support gc profile (theanarkh) #46255 vm: * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
juanarbol
force-pushed
the
v18.15.0-proposal
branch
from
6b8ecaa
to
6859857
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@juanarbol any reason #46839 is not in the release? |
|
juanarbol
force-pushed
the
v18.15.0-proposal
branch
from
6859857
to
6110438
Compare
juanarbol
added a commit
that referenced
this pull request
Mar 3, 2023
Notable Changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
This comment was marked as outdated.
This comment was marked as outdated.
|
@juanarbol What about #46721 to fix #46234? |
|
Please add #46767 |
17 tasks
The description contains incorrect reference to the node pull request #2 which is picked up from the original commit message (That is actually a reference to the fork's pulls request.) @juanarbol, I'm not sure what the procedures would be to correct this, But I have to express my apologies for the the inconveniences I'm caused of. |
17 tasks
I don't see any problem amending the commit message; I would like to know from other @nodejs/releasers @sepehrst could you please give me the right commit message? |
Just the |
Yeah, I can do that :)
Landed!
Landed!
Landed! Thank you all for the heads-up! And the nice catches! Appreciated, this release will be better <3 |
Original commit message:
[bigint] Convert BigInt property names to decimal
Hexadecimal/octal/binary BigInt property names should be converted
to decimal, i.e. the following object literals should all be equivalent:
var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.
Test case by yangwenming@bytedance.com, uploaded at
https://chromium-review.googlesource.com/c/v8/v8/+/3634937
Fixed: v8:10600
Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80490}
Refs: v8/v8@c875e86
PR-URL: #46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself. PR-URL: #45886 Backport-PR-URL: #46330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After #46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: #46720 Backport-PR-URL: #46839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This reverts commit dee882e. Moved the test that demonstrated what this commit was fixing to the `known_issues` folder. Fixes: #46234 PR-URL: #46721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message:
[intl] Revert date formatting behavior change from ICU 72
Replace U+202F with U+0020 after formatting date. This lets websites
continue to work without any changes.
This matches Firefox behavior, according to
https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.
Bug: chromium:1414292, chromium:1401829, chromium:1392814
Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85757}
Refs: v8/v8@90be99f
PR-URL: #46646
Refs: #46123
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
juanarbol
force-pushed
the
v18.15.0-proposal
branch
2 times, most recently
from
c1d6a15
to
fceac82
Compare
juanarbol
added a commit
that referenced
this pull request
Mar 5, 2023
Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
This comment was marked as outdated.
This comment was marked as outdated.
Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
juanarbol
force-pushed
the
v18.15.0-proposal
branch
from
fceac82
to
a94966f
Compare
20 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
The stand outs from that are npm@9.6.0 and undici@5.20.0. npm@9.6.0 at least was released after Node.js 18.14.1 was. I'd suggest running another CITGM for 18.14.1 and using that as the baseline to compare the CITGM for this PR against. |
19 tasks
|
FAILURE: 43 failures in 3131 not present in 3135
┌────────────────────────┬───────────────────┬─────────────────────────┬─────────────────────────┬───────────────────────┬─────────────────────────┬──────────────────────┬─────────────────┐
│ (index) │ 0 │ 1 │ 2 │ 3 │ 4 │ 5 │ 6 │
├────────────────────────┼───────────────────┼─────────────────────────┼─────────────────────────┼───────────────────────┼─────────────────────────┼──────────────────────┼─────────────────┤
│ win-vs2019 │ 'async-v3.2.4' │ 'body-parser-v1.20.2' │ 'prom-client-v14.1.1' │ │ │ │ │
│ fedora-last-latest-x64 │ 'bcrypt-v5.1.0' │ 'bluebird-v3.7.2' │ 'ava-v5.2.0' │ 'fastify-v4.14.0' │ 'level-v8.0.0' │ 'jest-v29.4.3' │ │
│ rhel8-ppc64le │ 'esprima-v4.0.1' │ 'csv-parser-v3.0.0' │ 'fastify-v4.14.0' │ 'resolve-v1.22.1' │ 'prom-client-v14.1.1' │ 'rimraf-v4.3.0' │ 'rewire-v6.0.0' │
│ rhel8-s390x │ 'fastify-v4.14.0' │ 'rewire-v6.0.0' │ 'rimraf-v4.3.0' │ 'tough-cookie-v4.1.2' │ 'torrent-stream-v1.2.1' │ │ │
│ aix72-ppc64 │ 'fastify-v4.14.0' │ 'rimraf-v4.3.0' │ 'torrent-stream-v1.2.1' │ │ │ │ │
│ rhel8-x64 │ 'jest-v29.4.3' │ 'torrent-stream-v1.2.1' │ │ │ │ │ │
│ debian10-x64 │ 'async-v3.2.4' │ 'pino-v8.11.0' │ 'serialport-v10.5.0' │ 'jest-v29.4.3' │ │ │ │
│ ubuntu1804-64 │ 'async-v3.2.4' │ 'pino-v8.11.0' │ 'serialport-v10.5.0' │ 'jest-v29.4.3' │ 'torrent-stream-v1.2.1' │ │ │
│ fedora-latest-x64 │ 'fastify-v4.14.0' │ 'inherits-v2.0.4' │ 'jest-v29.4.3' │ 'ember-cli-v4.11.0' │ 'leveldown-v6.1.1' │ 'serialport-v10.5.0' │ │
│ osx1015 │ 'fastify-v4.14.0' │ 'ember-cli-v4.11.0' │ │ │ │ │ │
└────────────────────────┴───────────────────┴─────────────────────────┴─────────────────────────┴───────────────────────┴─────────────────────────┴──────────────────────┴─────────────────┘ |
|
FAILURE: 19 failures in 3136 not present in 3135
┌────────────────────────┬─────────────────────────┬─────────────────────────┬──────────────────────┐
│ (index) │ 0 │ 1 │ 2 │
├────────────────────────┼─────────────────────────┼─────────────────────────┼──────────────────────┤
│ rhel8-s390x │ 'torrent-stream-v1.2.1' │ │ │
│ fedora-last-latest-x64 │ 'bcrypt-v5.1.0' │ 'undici-v5.20.0' │ │
│ aix72-ppc64 │ 'async-v3.2.4' │ 'torrent-stream-v1.2.1' │ │
│ rhel8-x64 │ 'torrent-stream-v1.2.1' │ │ │
│ win-vs2019 │ 'async-v3.2.4' │ 'fastify-v4.14.1' │ │
│ debian10-x64 │ 'bcrypt-v5.1.0' │ 'leveldown-v6.1.1' │ │
│ ubuntu1804-64 │ 'async-v3.2.4' │ 'pino-v8.11.0' │ 'serialport-v10.5.0' │
│ rhel8-ppc64le │ 'level-v8.0.0' │ 'vinyl-v3.0.0' │ 'ws-v8.12.1' │
│ fedora-latest-x64 │ 'async-v3.2.4' │ 'ember-cli-v4.11.0' │ │
│ osx1015 │ 'ember-cli-v4.11.0' │ │ │
└────────────────────────┴─────────────────────────┴─────────────────────────┴──────────────────────┘ |
BethGriggs
approved these changes
Mar 7, 2023
juanarbol
added a commit
that referenced
this pull request
Mar 7, 2023
Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-03-07, Version 18.15.0 'Hydrogen' (LTS), @BethGriggs prepared by @juanarbol
Notable Changes
63563f8a7a] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #4601728a775b32f] - test_runner: add initial code coverage support (Colin Ihrig) #460174d50db14b3] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #45712643545ab79] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #46358110ead9abb] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #4632002632b42cf] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255f09b838408] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #46218cb5bb12422] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046Commits
6f91c8e2ae] - benchmark: add trailing commas (Antoine du Hamel) #46370d0b9be21eb] - benchmark: remove buffer benchmarks redundancy (Brian White) #457356468f30d0d] - benchmark: introduce benchmark combination filtering (Brian White) #45735cb5bb12422] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046ec61bb04c0] - build: export more OpenSSL symbols on Windows (Mohamed Akram) #454867bae4333ce] - build: fix MSVC 2022 Release compilation (Vladimir Morozov (REDMOND)) #462280f5f2d4470] - crypto: includehmac.hincrypto_util.h(Adam Langley) #4627991ece4161b] - crypto: avoid hang when no algorithm available (Richard Lau) #46237492fc95bdf] - deps: V8: cherry-pick 90be99fab31c (Michaël Zasso) #46646732c77e3d9] - deps: update acorn to 8.8.2 (Node.js GitHub Bot) #463638582f99ffb] - deps: update to uvwasi 0.0.15 (Colin Ihrig) #462535453cd9940] - deps: V8: cherry-pick bf0bd4868dde (Michaël Zasso) #459083ea53c5dc8] - deps: V8: cherry-pick c875e86df1d7 (sepehrst) #46501c04808de4b] - doc: correct thesedcommand for macOS in release process docs (Juan José) #463978113220690] - doc: pass string totextEncoder.encodeas input (Deokjin Kim) #46421129dccf5d2] - doc: add tip for session.post function (theanarkh) #46354919e581732] - doc: add documentation for socket.destroySoon() (Luigi Pinca) #46337fc15ac95a5] - doc: fix commit message using test instead of deps (Tony Gorez) #46313d153a93200] - doc: add v8 fast api contribution guidelines (Yagiz Nizipli) #46199dbf082d082] - doc: fix small typo error (0xflotus) #4618694421b4cfe] - doc: mark some parameters as optional in webstreams (Deokjin Kim) #462695adb743511] - doc: update output of example inevents.getEventListeners(Deokjin Kim) #4626863563f8a7a] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #460174e88c7c813] - esm: delete preload mock test (Geoffrey Booth) #46402643545ab79] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #463585019b5473f] - http: res.setHeaders first implementation (Marco Ippolito) #4610976622c4c60] - inspector: allow opening inspector whenNODE_V8_COVERAGEis set (Moshe Atlow) #4611392f0747e03] - meta: update AUTHORS (Node.js GitHub Bot) #46399795251bc6f] - meta: update AUTHORS (Node.js GitHub Bot) #463038865424c31] - meta: add .mailmap entry (Rich Trott) #463035ed679407b] - meta: move evanlucas to emeritus (Evan Lucas) #46274403df210ac] - module: move test reporter loading (Geoffrey Booth) #459232f7319e387] - readline: fix detection of carriage return (Antoine du Hamel) #4630673a8f46c4d] - Revert "src: let http2 streams end after session close" (Santiago Gimeno) #4672130d783f91a] - src: stop tracing agent before shutting down libuv (Santiago Gimeno) #463801508d90fda] - src: get rid of fp arithmetic in ParseIPv4Host (Tobias Nießen) #46326bdb793a082] - src: use UNREACHABLE instead of CHECK(falsy) (Tobias Nießen) #46317116a33649b] - src: add support for ETW stack walking (José Dapena Paz) #46203b06298c98e] - src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid (Miguel Teixeira) #4622726f41b041c] - src: fix c++ exception on bad command line arg (Ben Noordhuis) #4629014da89f41a] - src: remove unreachable UNREACHABLE (Tobias Nießen) #4628118c4dd004b] - src: replace custom ASCII validation with simdutf one (Anna Henningsen) #46271cde375510f] - src: replace unreachable code with static_assert (Tobias Nießen) #46250f389b2f3fc] - src: use explicit C++17 fallthrough (Tobias Nießen) #462518adaa1333c] - src: use CreateEnvironment instead of inlining its code where possible (Anna Henningsen) #45886f09b838408] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #4621863e92eae63] - stream: remove brandchecks from stream duplexify (Debadree Chatterjee) #463153acfe9bf92] - stream: fix readable stream as async iterator function (Erick Wendel) #46147de64315ccb] - test: fix WPT title when no META title is present (Filip Skokan) #46804162e3400ff] - test: fix default WPT titles (Filip Skokan) #467785f422c4d70] - test: add WPTRunner support for variants and generating WPT reports (Filip Skokan) #464984f5aff2557] - test: fix tap parser fails if a test logs a number (Pulkit Gupta) #4605632b020cf84] - test: fix tap escaping with and without --test (Pulkit Gupta) #46311f2bba1bcdb] - test: add trailing commas intest/node-api(Antoine du Hamel) #46384f2ebe66fda] - test: add trailing commas intest/message(Antoine du Hamel) #46372ed564a9985] - test: add trailing commas intest/pseudo-tty(Antoine du Hamel) #46371e4437dd409] - test: set common.bits to 64 for loong64 (Shi Pujin) #453839d40aef736] - test: s390x zlib test case fixes (Adam Majer) #46367ed3fb52716] - test: fix logInTimeout is not function (theanarkh) #46348d05b0771be] - test: avoid trying to call sysctl directly (Adam Majer) #46366041aac3bbd] - test: avoid left behind child processes (Richard Lau) #46276837ddcb322] - test: add failing test for readline with carriage return (Alec Mev) #4607575b8db41c6] - test: reducefs-write-optional-paramsflakiness (LiviaMedeiros) #46238c0d3fdaf63] - test,crypto: add CFRG curve vectors to wrap/unwrap tests (Filip Skokan) #46406f328f7b15e] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #462671ef3c53e24] - test_runner: better handle async bootstrap errors (Colin Ihrig) #467200a690efb76] - test_runner: adddescribe.onlyandit.onlyshorthands (Richie McColl) #4660428a1317efe] - test_runner: bootstrap reporters before running tests (Moshe Atlow) #46737cd3aaa8fac] - test_runner: emit test-only diagnostic warning (Richie McColl) #46540c19fa45a65] - test_runner: centralize CLI option handling (Colin Ihrig) #467070898145e37] - test_runner: display skipped tests in spec reporter output (Richie McColl) #46651894d7117fa] - test_runner: parse non-ascii character correctly (Mert Can Altın) #457365b3c606626] - test_runner: flatten TAP output when running using--test(Moshe Atlow) #46440391ff0dba4] - test_runner: allow nesting test within describe (Moshe Atlow) #46544ba784e87b4] - test_runner: fix missing test diagnostics (Moshe Atlow) #46450c5f16fb5fb] - test_runner: top-level diagnostics not ommited when running with --test (Pulkit Gupta) #4644128a775b32f] - test_runner: add initial code coverage support (Colin Ihrig) #460170d999e373a] - test_runner: make built in reporters internal (Colin Ihrig) #4609279f4b426fe] - test_runner: reportfilein test runner events (Moshe Atlow) #460304d50db14b3] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #457125fdf374c74] - test_runner: avoid swallowing of asynchronously thrown errors (MURAKAMI Masahiko) #4526423b875806c] - test_runner: update comment to comply with eslint no-fallthrough rule (Antoine du Hamel) #4625800c5495aa3] - tools: update eslint to 8.33.0 (Node.js GitHub Bot) #4640037a6ce1120] - tools: update doc to unist-util-select@4.0.3 unist-util-visit@4.1.2 (Node.js GitHub Bot) #463641eaafc7db4] - tools: update lint-md-dependencies to rollup@3.12.0 (Node.js GitHub Bot) #46398a97774603b] - tools: require more trailing commas (Antoine du Hamel) #4634603e244a59b] - tools: update lint-md-dependencies (Node.js GitHub Bot) #4630260d714e0c3] - tools: allow icutrim.py to run on python2 (Michael Dawson) #46263b7950f50de] - tools: update eslint to 8.32.0 (Node.js GitHub Bot) #4625808bafc84f6] - url: refactor to use more primordials (Antoine du Hamel) #4596602632b42cf] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255110ead9abb] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320