doc: diagnostics_channel added in v14.17.0 #46984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
diagnostics_channel
tlhunter
force-pushed
the
patch-2
branch
3 times, most recently
from
f17a68c
to
83d3f06
Compare
Qard
approved these changes
Mar 6, 2023
anonrig
approved these changes
Mar 7, 2023
VoltrexKeyva
approved these changes
Mar 7, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0.
lpinca
approved these changes
Mar 7, 2023
lpinca
added
fast-track
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/46984 ✔ Done loading data for nodejs/node/pull/46984 ----------------------------------- PR info ------------------------------------ Title doc: diagnostics_channel added in v14.17.0 (#46984) Author Thomas Hunter II (@tlhunter) Branch tlhunter:patch-2 -> nodejs:main Labels doc, fast-track, diagnostics_channel Commits 1 - doc: fix history information for `node:diagnostics_channel` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/46984 Reviewed-By: Stephen Belanger Reviewed-By: Yagiz Nizipli Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46984 Reviewed-By: Stephen Belanger Reviewed-By: Yagiz Nizipli Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 06 Mar 2023 22:59:57 GMT ✔ Approvals: 4 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327381744 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327491048 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327714426 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46984#pullrequestreview-1329456433 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4358230515 |
nodejs-github-bot
added
the
commit-queue-failed
Flarna
approved these changes
Mar 8, 2023
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8b02df9 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0. PR-URL: #46984 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0. PR-URL: #46984 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0. PR-URL: #46984 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diagnostics_channelmodule was backported to Node.js v14.17.0