Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.8.0 release proposal #47087

Merged
merged 216 commits into from Mar 14, 2023
Merged

v19.8.0 release proposal #47087

merged 216 commits into from Mar 14, 2023

Commits on Mar 13, 2023

  1. test_runner: display skipped tests in spec reporter output

    PR-URL: #46651
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    richiemccoll authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    66016e2 View commit details
    Browse the repository at this point in the history
  2. test: update web-platform tests for url

    PR-URL: #46547
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    anonrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    95bbd0f View commit details
    Browse the repository at this point in the history
  3. url: fix url spec compliance issues

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
    PR-URL: #46547
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    2 people authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9d55a5e View commit details
    Browse the repository at this point in the history
  4. url: improve performance by removing host

    PR-URL: #46547
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    anonrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a524055 View commit details
    Browse the repository at this point in the history
  5. deps: update simdutf to 3.2.0

    PR-URL: #46621
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fb146ee View commit details
    Browse the repository at this point in the history
  6. stream: fix pipeline callback not called on ended stream

    Fixes: #46595
    PR-URL: #46600
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    debadree25 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1f38657 View commit details
    Browse the repository at this point in the history
  7. tools: update wpt.fyi used daily checkout ref

    PR-URL: #46730
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    617b5b1 View commit details
    Browse the repository at this point in the history
  8. lib: add AsyncLocalStorage.bind() and .snapshot()

    PR-URL: #46387
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    flakey5 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c1651be View commit details
    Browse the repository at this point in the history
  9. src: implement DataQueue

    See documentation in dataqueue/queue.h for details
    
    Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
    PR-URL: #45258
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9b6270a View commit details
    Browse the repository at this point in the history
  10. src: update Blob implementation to use DataQueue / File-backed Blobs

    Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
    PR-URL: #45258
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    36f36b9 View commit details
    Browse the repository at this point in the history
  11. src, lib: fixup lint and format issues for DataQueue/Blob

    Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
    PR-URL: #45258
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d48ed95 View commit details
    Browse the repository at this point in the history
  12. cluster: add trailing commas in source files

    PR-URL: #46695
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    16bbbac View commit details
    Browse the repository at this point in the history
  13. fs: add trailing commas in source files

    PR-URL: #46696
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4c12e6e View commit details
    Browse the repository at this point in the history
  14. lib: add trailing commas in internal/perf

    PR-URL: #46697
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7b5c00a View commit details
    Browse the repository at this point in the history
  15. os: improve network interface performance

    This reduces the overhead of getCIDR() to a minimum. No array is
    allocated anymore and parts are directly sliced out of the netmask
    string instead.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46598
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e5b8597 View commit details
    Browse the repository at this point in the history
  16. test_runner: centralize CLI option handling

    The test runner relies on a few CLI options. That code was spread
    across a few locations. This commit centralizes that logic.
    
    PR-URL: #46707
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    320ddc0 View commit details
    Browse the repository at this point in the history
  17. test: use newish OpenSSL feature in test-tls-dhe

    According to the comment that is being replaced here, this was not
    possible with the current version of OpenSSL 1.0.2 at the time the test
    was written. New OpenSSL versions appear to always print the length of
    the temporary key.
    
    Refs: nodejs/node-v0.x-archive#8272
    PR-URL: #46708
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3401315 View commit details
    Browse the repository at this point in the history
  18. tools: update lint-md-dependencies to rollup@3.17.0

    PR-URL: #46712
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b7e027a View commit details
    Browse the repository at this point in the history
  19. tools: update lint-md-dependencies to rollup@3.17.1

    PR-URL: #46712
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6ff0b80 View commit details
    Browse the repository at this point in the history
  20. assert: remove deprecated getFunction() usage

    The method is meant to be removed by the V8 team. It is not a
    critical functionality that is removed, therefore no alternative
    is checked for either.
    
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46661
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a38de61 View commit details
    Browse the repository at this point in the history
  21. deps: V8: cherry-pick 90be99fab31c

    Original commit message:
    
        [intl] Revert date formatting behavior change from ICU 72
    
        Replace U+202F with U+0020 after formatting date. This lets websites
        continue to work without any changes.
    
        This matches Firefox behavior, according to
        https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.
    
        Bug: chromium:1414292, chromium:1401829, chromium:1392814
        Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
        Commit-Queue: Adam Klein <adamk@chromium.org>
        Reviewed-by: Shu-yu Guo <syg@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#85757}
    
    Refs: v8/v8@90be99f
    PR-URL: #46646
    Refs: #46123
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c786ed3 View commit details
    Browse the repository at this point in the history
  22. benchmark: rework assert benchmarks for correctness

    This reworks most assert benchmarks to provide more reliable test
    cases that also test more cases than before while keeping the
    runtime low.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46593
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    86b3621 View commit details
    Browse the repository at this point in the history
  23. test: remove obsolete util.isDeepStrictEqual tests

    These tests are a copy of the assert tests that verify the
    deep equal comparison algorithm. There is no need to duplicate the
    tests as changing one would require to change the tests in two
    places without knowing which ones to actually rely upon.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46593
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    abba45e View commit details
    Browse the repository at this point in the history
  24. assert,util: improve deep equal comparison performance

    This is mainly a performance improvement for a lot of simple cases.
    Diverging elements are detected earlier and equal entries are
    partially also detected faster.
    
    A small correctness patch is also included where recursions now
    stop as soon as either side has a circular structure. Before, both
    sides had to have a circular structure at the specific comparison
    which could have caused more checks that likely fail at a later
    point.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46593
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7f85a2c View commit details
    Browse the repository at this point in the history
  25. assert,util: revert recursive breaking change

    This commit is there to be reverted after merging. It makes it easy
    to backport the overall PR and allows easy forward fixing.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46593
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    BridgeAR authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e07c9b8 View commit details
    Browse the repository at this point in the history
  26. doc: add emit to NodeEventTarget

    NodeEventTarget.emit() is not described in document. Plus, make
    type parameter of removeAllListeners as optional.
    
    Refs: #35851
    PR-URL: #46356
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    deokjinkim authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dd66c48 View commit details
    Browse the repository at this point in the history
  27. src: use string_view for report and related code

    Use `std::string_view` for process.report code and related
    code, drop a few unnecessary `std::to_string` calls,
    and use `MaybeStackBuffer` instead of `MallocedBuffer`,
    all in order to avoid unnecessary heap allocations.
    
    PR-URL: #46723
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    addaleax authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    19b5d07 View commit details
    Browse the repository at this point in the history
  28. events: add listener argument to listenerCount

    PR-URL: #46523
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    ShogunPanda authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2eb8875 View commit details
    Browse the repository at this point in the history
  29. http: unify header treatment

    PR-URL: #46528
    Fixes: #46395
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6f9cb98 View commit details
    Browse the repository at this point in the history
  30. test: fix flaky test-watch-mode-files_watcher

    PR-URL: #46738
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    MoLow authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d5784c7 View commit details
    Browse the repository at this point in the history
  31. Revert "src: let http2 streams end after session close"

    This reverts commit dee882e.
    Moved the test that demonstrated what this commit was fixing to the
    `known_issues` folder.
    
    Fixes: #46234
    PR-URL: #46721
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Trott authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    518b890 View commit details
    Browse the repository at this point in the history
  32. lib: update punycode to 2.3.0

    PR-URL: #46719
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    anonrig authored and targos committed Mar 13, 2023
    1 Configuration menu
    Copy the full SHA
    1c6a92b View commit details
    Browse the repository at this point in the history
  33. punycode: add pending deprecation

    PR-URL: #46719
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d3d76c3 View commit details
    Browse the repository at this point in the history
  34. src: add SetFastMethodNoSideEffect()

    The original SetFastMethod() uses v8::SideEffectType::kHasNoSideEffect
    by default, which is different from SetMethod(). Follow the
    previous convention and add a new SetFastMethodNoSideEffect()
    instead.
    
    PR-URL: #46619
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ad5f42d View commit details
    Browse the repository at this point in the history
  35. meta: update AUTHORS

    PR-URL: #46726
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9d63ac2 View commit details
    Browse the repository at this point in the history
  36. tools: update-nghttp2 preserve config.h

    PR-URL: #46698
    Refs: #45572
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2ff9b20 View commit details
    Browse the repository at this point in the history
  37. tools: update nghttp2 action

    PR-URL: #46700
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a560a78 View commit details
    Browse the repository at this point in the history
  38. tools: fixed path

    PR-URL: #46700
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dd40034 View commit details
    Browse the repository at this point in the history
  39. doc: maintaining nghttp2

    PR-URL: #46539
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7806cae View commit details
    Browse the repository at this point in the history
  40. tools: fix regex strings in Python tools

    PR-URL: #46671
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    josusky authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    25ccaa7 View commit details
    Browse the repository at this point in the history
  41. doc: clarify semver-minor notable changes approach

    Clarifies the current approach taken by releasers when crafting notable
    changes for releases. This approach is also in line with the
    implementation of the `git node release --prepare` tooling.
    
    PR-URL: #46592
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BethGriggs authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d627164 View commit details
    Browse the repository at this point in the history
  42. src: per-realm binding data

    Binding data is inherited from BaseObject and created in a specific
    realm. They need to be tracked on a per-realm basis so that they can
    be released properly when a realm is disposed.
    
    PR-URL: #46556
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    legendecas authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    973287a View commit details
    Browse the repository at this point in the history
  43. tools: use actions pinned by commit hash in coverage-linux

    Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
    
    PR-URL: #46294
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    gabibguti authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1756830 View commit details
    Browse the repository at this point in the history
  44. tls: add trailing commas in source files

    PR-URL: #46715
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4df0084 View commit details
    Browse the repository at this point in the history
  45. debugger: add trailing commas in source files

    PR-URL: #46714
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    83b529f View commit details
    Browse the repository at this point in the history
  46. build,test: add proper support for IBM i

    Python 3.9 on IBM i now properly returns "os400" for sys.platform
    instead of claiming to be AIX as it did previously. While the IBM i PASE
    environment is compatible with AIX, it is a subset and has numerous
    differences which makes it beneficial to distinguish, however this means
    that it now needs explicit support here.
    
    PR-URL: #46739
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    dmabupt authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d4899b2 View commit details
    Browse the repository at this point in the history
  47. test: remove OpenSSL 1.0.2 error message compat

    While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified
    to recognize error messages from both OpenSSL releases. Given that
    OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the
    older message patterns.
    
    Refs: #16130
    PR-URL: #46709
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f4cdc6f View commit details
    Browse the repository at this point in the history
  48. tools: cleanup WPT refs in daily-wpt-fyi.yml

    PR-URL: #46740
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    694659c View commit details
    Browse the repository at this point in the history
  49. wasi: add support for version when creating WASI

    Refs: #46254
    
    - add version to options when creating WASI object
    - add convenience function to return importObject
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46469
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mhdawson authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    60e5f45 View commit details
    Browse the repository at this point in the history
  50. doc: add in security steward for recent release

    - add in security steward for recent release
    - add in next set of rotation entries
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46701
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Joe Sepi <sepi@joesepi.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mhdawson authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    88057dd View commit details
    Browse the repository at this point in the history
  51. deps: fix libuv for android

    Fix android build errors introduced by the upgrade to libuv 1.44.2
    
    Fixes: #46743
    Fixes: #46744
    PR-URL: #46746
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nappy authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d9069e7 View commit details
    Browse the repository at this point in the history
  52. deps: update nghttp2 to 1.52.0

    Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
    PR-URL: #46636
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    68dde38 View commit details
    Browse the repository at this point in the history
  53. src: use an array for faster binding data lookup

    Locally the hashing of the binding names sometimes has significant
    presence in the profile of bindings, because there can be collisions,
    which makes the cost of adding a new binding data non-trivial,
    but it's wasteful to spend time on hashing them or dealing with
    collisions at all, since we can just use the EmbedderObjectType
    enum as the key, as the string names are not actually used beyond
    debugging purposes and can be easily matched with a macro.
    And since we can just use the enum as the key, we do not even
    need the map and can just use an array with the enum as indices
    for the lookup.
    
    PR-URL: #46620
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c0fcad3 View commit details
    Browse the repository at this point in the history
  54. doc: include context on .toWeb() parameters

    Refs: #46347
    PR-URL: #46617
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1b3a25e View commit details
    Browse the repository at this point in the history
  55. test: fix default WPT titles

    PR-URL: #46778
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b2cfcf9 View commit details
    Browse the repository at this point in the history
  56. doc: add test:coverage event to custom reporter examples

    PR-URL: #46752
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    richiemccoll authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fc319d6 View commit details
    Browse the repository at this point in the history
  57. net: rework autoSelectFamily implementation

    PR-URL: #46587
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ShogunPanda authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e0d098b View commit details
    Browse the repository at this point in the history
  58. http: fix validation of "Link" header

    Updated regex for "Link" header validation to better match the
    specification in RFC 8288 section 3. Does not check for valid URI
    format but handles the rest of the header more permissively than
    before. Alternative to another outstanding PR that disables validation
    entirely.
    
    Fixes: #46453
    Refs: https://www.rfc-editor.org/rfc/rfc8288.html#section-3
    Refs: #46464
    PR-URL: #46466
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    SRHerzog authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e08514e View commit details
    Browse the repository at this point in the history
  59. http: correctly calculate strict content length

    Fixes some logical errors related to strict content length.
    
    Also, previously Buffer.byteLength (which is slow) was run regardless of
    whether or not the len was required.
    
    PR-URL: #46601
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    ronag authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    aac5c28 View commit details
    Browse the repository at this point in the history
  60. benchmark: fix worker startup benchmark

    It previously called spawnProcess in spawnWorker, which was
    incorrect.
    
    PR-URL: #46680
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9890eaa View commit details
    Browse the repository at this point in the history
  61. test: fix IPv6 checks on IBM i

    PR-URL: #46546
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    abmusse authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2c4f670 View commit details
    Browse the repository at this point in the history
  62. doc: add document for profiling and heap snapshot

    PR-URL: #46787
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cola119 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    00edc50 View commit details
    Browse the repository at this point in the history
  63. doc: document how to use the tls.DEFAULT_CIPHERS

    The DEFAULT_CIPHERS already exists, this change shows how to use it.
    
    Fixes: #46462
    PR-URL: #46482
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    andreas-ibm authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    60d1a48 View commit details
    Browse the repository at this point in the history
  64. test: include strace openat test

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #46150
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4e9915e View commit details
    Browse the repository at this point in the history
  65. node-api: add __wasm32__ guards on async works

    PR-URL: #46633
    Refs: #33597
    Refs: nodejs/node-addon-api#1283
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    58b1f33 View commit details
    Browse the repository at this point in the history
  66. repl: add trailing commas in source files

    PR-URL: #46757
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4f2bf8c View commit details
    Browse the repository at this point in the history
  67. child_process: add trailing commas in source files

    PR-URL: #46758
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    81592ff View commit details
    Browse the repository at this point in the history
  68. test: improve control flow in test-tls-dhe

    If this test fails, e.g., if the s_client output does not match the
    expectation, the previous implementation would not produce any helpful
    error messages. Rework the control flow to be more idiomatic. Avoid
    callback chaining and stream operations.
    
    Also, the TLS server 'close' event does not pass an error to the event
    handler, so remove the respective assertion.
    
    PR-URL: #46751
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a92be13 View commit details
    Browse the repository at this point in the history
  69. tools: run format-cpp on node-api test c files

    PR-URL: #46694
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f6bd145 View commit details
    Browse the repository at this point in the history
  70. test: fix test-v8-collect-gc-profile-in-worker.js

    PR-URL: #46735
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    theanarkh authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9c7a2e3 View commit details
    Browse the repository at this point in the history
  71. stream: fix respondWithNewView() errors when view.byteOffset != 0

    Fixes: #42851
    Refs: https://github.com/whatwg/streams/blob/f894acdd417926a2121710803cef593e15127964/reference-implementation/lib/abstract-ops/readable-streams.js#L1756
    PR-URL: #46465
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    debadree25 authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    93e91f3 View commit details
    Browse the repository at this point in the history
  72. test_runner: better handle async bootstrap errors

    The test runner is bootstrapped synchronously, with the exception
    of importing custom reporters. To better handle asynchronously
    throw errors, this commit introduces an internal error type that
    can be checked for from the test runner's uncaughtException
    handler.
    
    After #46707 and this change
    land, the other throw statement in the uncaughtException handler
    can be removed. This will allow the test runner to handle errors
    thrown from outside of tests (which currently prevents the test
    runner from reporting results).
    
    PR-URL: #46720
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    cjihrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dfe529b View commit details
    Browse the repository at this point in the history
  73. meta: update CODEOWNERS of url implementations

    PR-URL: #46775
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    anonrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4e0b932 View commit details
    Browse the repository at this point in the history
  74. deps: update ada to 1.0.3

    PR-URL: #46784
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4e18e0a View commit details
    Browse the repository at this point in the history
  75. url: simplify and improve url formatting

    PR-URL: #46736
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5a3ad87 View commit details
    Browse the repository at this point in the history
  76. doc: add marco-ippolito to collaborators

    Fixes: #46660
    PR-URL: #46816
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    marco-ippolito authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    bd5ef38 View commit details
    Browse the repository at this point in the history
  77. url: implement URLSearchParams size getter

    Refs: whatwg/url#734
    PR-URL: #46308
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    jasnell authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1e20b05 View commit details
    Browse the repository at this point in the history
  78. deps: upgrade npm to 9.5.1

    PR-URL: #46783
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    npm-cli-bot authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    92f2f19 View commit details
    Browse the repository at this point in the history
  79. dgram: fix unhandled exception aborting a closed udp socket

    Fixes: #46750
    PR-URL: #46770
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vramana authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    247dfb7 View commit details
    Browse the repository at this point in the history
  80. test: remove unreachable return

    PR-URL: #46807
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jakecastelli authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e52ad92 View commit details
    Browse the repository at this point in the history
  81. meta: remove unnecessary onboarding step

    While it is nice to notify the TSC about accepted nominations,
    it is not strictly necessary and I think we should streamline
    things as much as possible.
    
    PR-URL: #46793
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c7f056c View commit details
    Browse the repository at this point in the history
  82. test: stop faking performance idlharness

    PR-URL: #46794
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3daf508 View commit details
    Browse the repository at this point in the history
  83. test: isolate hr-time specific wpt global init

    PR-URL: #46795
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    76a9634 View commit details
    Browse the repository at this point in the history
  84. test: remove useless require('../common') from WPTs

    PR-URL: #46796
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3234155 View commit details
    Browse the repository at this point in the history
  85. test_runner: add describe.only and it.only shorthands

    PR-URL: #46604
    Fixes: #46562
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    richiemccoll authored and targos committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    aa41f27 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. tools: update lint-md-dependencies to rollup@3.17.2

    PR-URL: #46771
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2f09d3f View commit details
    Browse the repository at this point in the history
  2. lib: fix DOMException property descriptors after being lazy loaded

    PR-URL: #46799
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    281f176 View commit details
    Browse the repository at this point in the history
  3. deps: update simdutf to 3.2.1

    PR-URL: #46800
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    151fb60 View commit details
    Browse the repository at this point in the history
  4. test: remove useless WPT init scripts

    PR-URL: #46801
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3ab1aab View commit details
    Browse the repository at this point in the history
  5. test: update encoding WPTs

    PR-URL: #46802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bd097ca View commit details
    Browse the repository at this point in the history
  6. tools: upload daily WPT Report to both staging and production

    PR-URL: #46803
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4b91420 View commit details
    Browse the repository at this point in the history
  7. test: fix WPT title when no META title is present

    PR-URL: #46804
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e5fa7a1 View commit details
    Browse the repository at this point in the history
  8. test: simplify test-tls-alert

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46805
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f21ed3a View commit details
    Browse the repository at this point in the history
  9. test: fix test-net-connect-reset-until-connected

    Fixes: #43446
    PR-URL: #46781
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    batrla authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e585a11 View commit details
    Browse the repository at this point in the history
  10. tools: update lint-md-dependencies to rollup@3.17.3

    PR-URL: #46843
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f4cbe4e View commit details
    Browse the repository at this point in the history
  11. benchmark: add benchmark for EventTarget add and remove

    Refs: nodejs/performance#60
    PR-URL: #46779
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    760a351 View commit details
    Browse the repository at this point in the history
  12. doc: add steps about signing the binary in single-executable docs

    We didn't catch this in #45038
    because the binary wasn't signed by default unlike the official Node.js
    binary, which is signed by the Node.js Foundation identity by default.
    
    Refs: nodejs/postject#76 (macOS arm64 part only)
    Fixes: nodejs/postject#75
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #46764
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    48cf984 View commit details
    Browse the repository at this point in the history
  13. lib: add trailing commas to more internal files

    PR-URL: #46811
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f914bff View commit details
    Browse the repository at this point in the history
  14. test: fix os-release check for Ubuntu in SEA test

    For example, my `/etc/os-release` file begins with
    
    ```
    PRETTY_NAME="Ubuntu 22.04.2 LTS"
    NAME="Ubuntu"
    VERSION_ID="22.04"
    ```
    
    so in order to match the regexp here, the `/m` flag is necessary.
    
    PR-URL: #46838
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    df155b8 View commit details
    Browse the repository at this point in the history
  15. deps: update corepack to 0.17.0

    PR-URL: #46842
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    8b1afe3 View commit details
    Browse the repository at this point in the history
  16. stream: always delay construct callback by a nextTick

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    Fixes: #46765
    PR-URL: #46818
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    mcollina authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4ad48d9 View commit details
    Browse the repository at this point in the history
  17. tools: fix linter message when using global DOMException

    Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
    PR-URL: #46822
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f558797 View commit details
    Browse the repository at this point in the history
  18. benchmark: split Buffer.byteLength benchmark

    PR-URL: #46616
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    04166fe View commit details
    Browse the repository at this point in the history
  19. buffer: use v8 fast API calls for Buffer.byteLength implementation

    Use v8 fast API calls for Buffer.byteLength with sequential one-byte
    strings.
    
    PR-URL: #46616
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b3e1034 View commit details
    Browse the repository at this point in the history
  20. assert: fix exception message for assert(0) on try catch block

    Fixes: #30872
    PR-URL: #46760
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    hidecology authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e11f08e View commit details
    Browse the repository at this point in the history
  21. buffer: add Buffer.copyBytesFrom(...)

    Fixes: #43862
    PR-URL: #46500
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2fece54 View commit details
    Browse the repository at this point in the history
  22. lib: rename internal module declaration as internal bindings

    This is a follow-up to #45551 .
    
    Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
    to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
    As these bindings are already loaded with the function internalBinding
    in the JS land, the term "internal binding" can be straightforward to
    be adopted.
    
    PR-URL: #46663
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    okmttdhr authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4e18651 View commit details
    Browse the repository at this point in the history
  23. stream: enable usage of webstreams on compose()

    Refs: #39316
    PR-URL: #46675
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f886681 View commit details
    Browse the repository at this point in the history
  24. tools: create llhttp update action

    PR-URL: #46766
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    724f9d6 View commit details
    Browse the repository at this point in the history
  25. bootstrap: print stack trace during environment creation failure

    #45888 took the environment
    creation code out of the scope covered by the v8::TryCatch
    that we use to print early failures during environment creation.
    So e.g. when adding something that would fail in node.js, we get
    
    ```
    node:internal/options:554: Uncaught Error: Should not query options before bootstrapping is done
    ```
    
    This patch restores that by adding another v8::TryCatch for it:
    
    ```
    node:internal/options:20
        ({ options: optionsMap } = getCLIOptions());
                                   ^
    
    Error: Should not query options before bootstrapping is done
        at getCLIOptionsFromBinding (node:internal/options:20:32)
        at getOptionValue (node:internal/options:45:19)
        at node:internal/bootstrap/node:433:29
    ```
    
    PR-URL: #46533
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cc74821 View commit details
    Browse the repository at this point in the history
  26. src: fix cb scope bugs involved in termination

    Be more aggresive to clean up the async id stack,
    and ensure the cleanup when terminating.
    
    Calling SetIdle() when terminating is not harmless.
    When node terminates due to an unhandled exception,
    v8 preseves the vm state, which is JS and notifies
    node through PerIsolateMessageListener(). If node
    calls SetIdle() later, v8 complains because it
    requires the vm state to either be EXTERNEL or IDLE
    when embedder calling SetIdle().
    
    PR-URL: #45596
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    ywave620 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9fab228 View commit details
    Browse the repository at this point in the history
  27. doc: use destructing import

    PR-URL: #46847
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jakecastelli authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9d2532e View commit details
    Browse the repository at this point in the history
  28. doc: sort import order

    PR-URL: #46847
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jakecastelli authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c0b6413 View commit details
    Browse the repository at this point in the history
  29. timers: use V8 fast API calls

    PR-URL: #46579
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    25069a6 View commit details
    Browse the repository at this point in the history
  30. doc: add history info for node:test

    PR-URL: #46851
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    8aca3cf View commit details
    Browse the repository at this point in the history
  31. meta: remove AUTHORS file

    The AUTHORS file does not serve any significant practical purpose and is
    a bit of a maintenance annoyance. Let's remove it.
    
    PR-URL: #46845
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b199acd View commit details
    Browse the repository at this point in the history
  32. deps: update ada to 1.0.4

    PR-URL: #46853
    Fixes: #46850
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b825e2d View commit details
    Browse the repository at this point in the history
  33. tools: update eslint to 8.35.0

    PR-URL: #46854
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    078600c View commit details
    Browse the repository at this point in the history
  34. src: do not track BaseObjects directly in Realm

    They are referenced through the CleanupQueue which is already
    tracked. Tracking them again in Realms results in duplicates in
    the heap snapshot.
    
    PR-URL: #46470
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    578a2c5 View commit details
    Browse the repository at this point in the history
  35. vm: fix leak in vm.compileFunction when importModuleDynamically is used

    Previously in the implementation there was a cycle that V8 could not
    detect:
    
    Strong global reference to CompiledFnEntry (JS wrapper)
        -> strong reference to callback setting (through the
           callbackMap key-value pair)
        -> importModuleDynamically (wrapper in internalCompileFunction())
        -> Strong reference to the compiled function (through closure in
           internalCompileFunction())
    
    The CompiledFnEntry only gets GC'ed when the compiled function is GC'ed.
    Since the compiled function is always reachable as described above,
    there is a leak.
    
    We only needed the first strong global reference because we didn't want
    the function to outlive the CompiledFnEntry. In this case it can be
    solved by using a private symbol instead of going with the global
    reference + destruction in the weak callback, which V8's GC is not
    going to understand.
    
    PR-URL: #46785
    Fixes: #42080
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    77b4aca View commit details
    Browse the repository at this point in the history
  36. src: remove shadowed variable in OptionsParser

    PR-URL: #46672
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    codebytere authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0d9c345 View commit details
    Browse the repository at this point in the history
  37. test: move socket from CWD to temporary directory

    PR-URL: #46863
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    LiviaMedeiros authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6fa142d View commit details
    Browse the repository at this point in the history
  38. lib: fix BroadcastChannel initialization location

    PR-URL: #46864
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    codebytere authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    08bf015 View commit details
    Browse the repository at this point in the history
  39. url: improve isURLThis detection

    PR-URL: #46866
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b10fe58 View commit details
    Browse the repository at this point in the history
  40. test: update web-platform tests for url

    PR-URL: #46860
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    meixg authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0e45470 View commit details
    Browse the repository at this point in the history
  41. tools: fix daily wpt nightly version selection

    PR-URL: #46891
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    132fc45 View commit details
    Browse the repository at this point in the history
  42. repl: fix .load infinite loop caused by shared use of lineEnding RegExp

    Since the lineEnding Regular Expression is declared on the module scope,
    recursive invocations of its `[kTtyWrite]` method share one instance of
    this Regular Expression.
    Since the state of a RegExp is managed by instance,
    alternately calling RegExpPrototypeExec with the same RegExp on
    different strings can lead to the state changing unexpectedly.
    This is the root cause of this infinite loop bug when calling .load on
    javascript files of certain shapes.
    
    PR-URL: #46742
    Fixes: #46731
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Theo-Steiner authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c7d4ff3 View commit details
    Browse the repository at this point in the history
  43. repl: remove lastInputPreview conditional check

    PR-URL: #46857
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    jenthone authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    56dbb15 View commit details
    Browse the repository at this point in the history
  44. src: make util.h self-containted

    Before it depended on util-inl.h. Fix it by moving
    MaybeStackBuffer::AllocateSufficientStorage() into
    util-inl.h
    
    PR-URL: #46817
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    32bd38f View commit details
    Browse the repository at this point in the history
  45. url: remove unused kFormat from url

    PR-URL: #46867
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f8765be View commit details
    Browse the repository at this point in the history
  46. doc: fix stream iterator helpers examples

    PR-URL: #46897
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    benjamingr authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    92a6138 View commit details
    Browse the repository at this point in the history
  47. deps: update uvwasi to v0.0.16

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46434
    Refs: nodejs/uvwasi#185
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mhdawson authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7ab7f97 View commit details
    Browse the repository at this point in the history
  48. wasi: add wasi sock_accept stub

    Refs: nodejs/uvwasi#185
    
    Add stub for sock_accept so that we have stubs
    for all of the sock methods in wasi_snapshot_preview1.
    Its a bit awkward as the method was added after the
    initial definitial of wasi_snapshot-preview1 but I
    think it should be semver minor at most to add
    the method.
    
    Depends on nodejs/uvwasi#185
    being landed in uvwasi first and an updated version
    of uvwasi that includes that being pulled into
    Node.js
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46434
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mhdawson authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b2a80d7 View commit details
    Browse the repository at this point in the history
  49. doc: add request to hold off publicising sec releases

    - We've often seen tweets go out early before announcement
      and other parts of the security release complete
    - Make an explicit ask that collaborators avoid doing this
      by gating on the tweet from the Node.js account
    - Releasers would still be free to tweet earlier as they know
      when the process is complete.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46702
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f9739a8 View commit details
    Browse the repository at this point in the history
  50. url: remove unnecessary call to FunctionPrototypeBind

    PR-URL: #46870
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b8560ec View commit details
    Browse the repository at this point in the history
  51. deps: update simdutf to 3.2.2

    PR-URL: #46841
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    fb1ac98 View commit details
    Browse the repository at this point in the history
  52. test: assume priv ports start at 1024 if it can't be changed

    An update to test/parallel/test-cluster-bind-privileged-port.js
    checks the lowest privileged port to ensure 42 is privileged
    This only works on kernels > 4.1. On older kernels, this is
    locked at 1024 so the check is not needed.
    
    Fixes: #45838
    PR-URL: #46536
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    KrayzeeKev authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    db2ace1 View commit details
    Browse the repository at this point in the history
  53. tools: refactor dep_updaters

    PR-URL: #46488
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tony-go authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ecce647 View commit details
    Browse the repository at this point in the history
  54. build: fix Visual Studio installation detection for Arm64

    PR-URL: #46420
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Blackhex authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4b3b009 View commit details
    Browse the repository at this point in the history
  55. url: set formatUrl method as no side effect

    PR-URL: #46884
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b1747fe View commit details
    Browse the repository at this point in the history
  56. src: fix missing trailing ,

    PR-URL: #46909
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zcbenz authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    074692a View commit details
    Browse the repository at this point in the history
  57. src: fix negative nodeTiming milestone values

    PR-URL: #46588
    Fixes: #45958
    Refs: #43781
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6740679 View commit details
    Browse the repository at this point in the history
  58. tools: add automation for updating OpenSSL dependency

    Add a Github Action that checks for new versions of the `OpenSSL`
    library, and creates a PR to update it if a newer version than the one
    present in the repo is found.
    
    Refs: nodejs/security-wg#828
    
    PR-URL: #45605
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    facutuesca authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f4a59b7 View commit details
    Browse the repository at this point in the history
  59. test: move testPath from CWD to temporary directory

    PR-URL: #46890
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    LiviaMedeiros authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e5b8896 View commit details
    Browse the repository at this point in the history
  60. esm: add a runtime warning when using import assertions

    PR-URL: #46901
    Refs: #46830
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2c621d6 View commit details
    Browse the repository at this point in the history
  61. doc: fix fs missing import

    PR-URL: #46907
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    jakecastelli authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    282bf29 View commit details
    Browse the repository at this point in the history
  62. doc: fix links to SSL_CTX_set_options

    The old 1.0.2 docs do not exist anymore; link to the same file for
    OpenSSL 3.0 instead.
    
    PR-URL: #46953
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    553fd5b View commit details
    Browse the repository at this point in the history
  63. doc: add release key for Juan Arboleda

    PR-URL: #46922
    Refs: nodejs/Release#829
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    juanarbol authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    07036cf View commit details
    Browse the repository at this point in the history
  64. test_runner: align behavior of it and test

    PR-URL: #46889
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    762dc7c View commit details
    Browse the repository at this point in the history
  65. test: simplify test-tls-ecdh-auto

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46911
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    21153f1 View commit details
    Browse the repository at this point in the history
  66. tools: update lint-md-dependencies to rollup@3.18.0

    PR-URL: #46935
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    8723844 View commit details
    Browse the repository at this point in the history
  67. doc: use number which is bigger than 1024 as port in http2

    With 80 port, user should run example with root permission.
    To avoid such situation, use 8000 or 8443 as port number
    in example of http2.
    
    PR-URL: #46938
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    deokjinkim authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1b555ae View commit details
    Browse the repository at this point in the history
  68. doc: fix port of destination server is not defined in http2

    `port` variable is used, but it's not defined in client code.
    So need to specify destination server(not proxy)'s port(8000)
    in client code.
    
    Refs: https://github.com/nodejs/node/blob/main/doc/api/http2.md#supporting-the-connect-method
    PR-URL: #46940
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    deokjinkim authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6f18b94 View commit details
    Browse the repository at this point in the history
  69. doc: improve fs code example quality

    PR-URL: #46948
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    jakecastelli authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ba5ff15 View commit details
    Browse the repository at this point in the history
  70. doc: fix description of TLS dhparam option

    The dhparam option is not required for perfect forward secrecy in
    general. It is only required for non-ECDHE secrecy, but ECDHE-based
    secrecy is generally preferred anyway.
    
    PR-URL: #46949
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5fdd3f4 View commit details
    Browse the repository at this point in the history
  71. worker: add support for worker name in inspector and trace_events

    Fixes: #41589
    PR-URL: #46832
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    debadree25 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a646a22 View commit details
    Browse the repository at this point in the history
  72. doc: remove useless SSL_OP_* options

    These 14 options do not have any effect in any supported version of
    OpenSSL.
    
    PR-URL: #46954
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f903ea5 View commit details
    Browse the repository at this point in the history
  73. test: improve test coverage of lib/dns

    PR-URL: #46910
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    paivaandeerson authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    acfd9b8 View commit details
    Browse the repository at this point in the history
  74. deps,test: update postject to 1.0.0-alpha.5

    PR-URL: #46934
    Fixes: nodejs/postject#76
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    adff278 View commit details
    Browse the repository at this point in the history
  75. test: update WPT resources, common, streams, FileAPI, broadcastchannel

    PR-URL: #46912
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c8d528e View commit details
    Browse the repository at this point in the history
  76. esm: fix import assertion warning

    Refs: #46901 (comment)
    PR-URL: #46971
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9d4d916 View commit details
    Browse the repository at this point in the history
  77. test_runner: give the root test a harness reference

    This commit replaces the 'coverage' reference inside of the Test
    class with a more generic harness reference which includes
    coverage. This will let the root test more easily track process
    level state such as code coverage, uncaughtException handlers,
    and the state of bootstrapping.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4b7198c View commit details
    Browse the repository at this point in the history
  78. test_runner: remove root tracking set

    The wasRootSetup Set in the test harness appears to be
    redundant, since the startTime field can be used interchangeably.
    This commit removes wasRootSetup.
    
    PR-URL: #46961
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    069ff1c View commit details
    Browse the repository at this point in the history
  79. benchmark: stablize encode benchmark

    - Increase the number of iteration to 1e6 to reduce flakes. 1e4
      can introduce flakes even when comparing the main branch
      against itself
    - Replace the 1024 * 32 length test with 1024 * 8 since it would
      otherwise take too long to complete. Remove the 16 length test
      since it's not too different from 32.
    - Check the results of the encoding methods at the end.
    
    PR-URL: #46658
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0617c5e View commit details
    Browse the repository at this point in the history
  80. src: move encoding bindings to a new binding

    Move the bindings used by TextEncoder to a new binding for
    more self-contained code.
    
    PR-URL: #46658
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    dcba3a0 View commit details
    Browse the repository at this point in the history
  81. src: use AliasedUint32Array for encodeInto results

    Getting the buffer from a TypedArray created from the JS land
    incurs a copy. For encodeInto() results we can just use an
    AliasedArray and let the binding always own the store.
    
    PR-URL: #46658
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6b60f38 View commit details
    Browse the repository at this point in the history
  82. src: remove unused v8::Uint32Array from encoding

    PR-URL: #47003
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9e65996 View commit details
    Browse the repository at this point in the history
  83. http: use listenerCount when adding noop event

    PR-URL: #46769
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ShogunPanda authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    774eb19 View commit details
    Browse the repository at this point in the history
  84. doc: fix myUrl is not defined in url

    Fixes a typo in the variable name in the URL code example in doc.
    Renames `myUrl` to `myURL` for consistency and readability.
    
    PR-URL: #46968
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    recrack authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    67e20f5 View commit details
    Browse the repository at this point in the history
  85. doc: fix history information for node:diagnostics_channel

    `node:diagnostics_channel` was backported to Node.js v14.17.0.
    
    PR-URL: #46984
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    tlhunter authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5f0f1c4 View commit details
    Browse the repository at this point in the history
  86. typings: improve primordials typings

    PR-URL: #46970
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    63a83b4 View commit details
    Browse the repository at this point in the history
  87. doc: add missing test runner flags to man page

    --test-reporter and --test-reporter-destination were previously
    missing from the man page.
    
    PR-URL: #46982
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    17d3eb0 View commit details
    Browse the repository at this point in the history
  88. src: remove use of SSL_OP_SINGLE_DH_USE

    This option does not have any effect in any supported OpenSSL version.
    
    Refs: #46954
    PR-URL: #46955
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b051ac7 View commit details
    Browse the repository at this point in the history
  89. src: remove TLSEXT_TYPE_alpn guard

    TLSEXT_TYPE_application_layer_protocol_negotiation is always defined in
    all supported OpenSSL versions. We also use this macro elsewhere without
    guards, so if it did not exist, compilation would have already failed.
    
    Besides that, it makes little sense to provide a TLS 1.3 implementation
    that does not support ALPN.
    
    PR-URL: #46956
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    815d2af View commit details
    Browse the repository at this point in the history
  90. test: simplify test-tls-ecdh-multiple

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46963
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5b81689 View commit details
    Browse the repository at this point in the history
  91. test,crypto: update WebCryptoAPI WPT

    PR-URL: #47010
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    13f14a5 View commit details
    Browse the repository at this point in the history
  92. meta: add single-executable labels and code owners

    PR-URL: #47004
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4219c1e View commit details
    Browse the repository at this point in the history
  93. url: fix array overrun in node:url::SetArgs()

    PR-URL: #47001
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e754277 View commit details
    Browse the repository at this point in the history
  94. net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout'

    Document describes that the value have to be 10 if passed value to
    `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10.
    So need to use 10 for 'if' statement and fix typo in document.
    
    Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue
    PR-URL: #47012
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    deokjinkim authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    40a7b0b View commit details
    Browse the repository at this point in the history
  95. doc: fix typo on esm loaders example

    Fixes a small typo on the Transpiler loader example.
    
    PR-URL: #47015
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ruyadorno authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cbdaaf6 View commit details
    Browse the repository at this point in the history
  96. tools: automate cares update

    PR-URL: #46993
    Refs: nodejs/security-wg#828
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    marco-ippolito authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2e7ba31 View commit details
    Browse the repository at this point in the history
  97. test: fallback to IPv4 if IPv6 is unavailable

    openssl seems to default to use IPv6.
    This change adds a checks if IPv6 is unavailable and uses IPv4 instead.
    On the Node.js CI IBM i build system IPv6 is currently disabled.
    This change should resolve the following test case failures:
    - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_psk_client_/
    - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_securepair_client_/
    
    PR-URL: #47017
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    abmusse authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9556d98 View commit details
    Browse the repository at this point in the history
  98. tools: dont use cached node versions in daily wpt

    PR-URL: #47024
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0f1ecbc View commit details
    Browse the repository at this point in the history
  99. doc,test: extend the list of platforms supported by single-executables

    Now that #46934 has landed, we can
    extend the list of platforms and architectures where we can run the
    single-executable test.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #47026
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RaisinTen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    458671d View commit details
    Browse the repository at this point in the history
  100. benchmark: replace table in docs with description of file tree structure

    The markdown table in `benchmark/README.md` has grown stale, no
    longer providing an overview over all existing benchmarks. As it has
    proven difficult to keep an exhaustive listing of available benchmarks
    up to date, this commit provides a description of how the directory is
    structured instead.
    
    PR-URL: #46991
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Theo-Steiner authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    258d5f7 View commit details
    Browse the repository at this point in the history
  101. test: move test-tls-autoselectfamily-servername to test/internet

    And switch from `google.com` to `nodejs.org`.
    
    PR-URL: #47029
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    11509a4 View commit details
    Browse the repository at this point in the history
  102. debugger: add a command to set which lines to check for context

    PR-URL: #46812
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Dailyscat authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    afbd818 View commit details
    Browse the repository at this point in the history
  103. tls: support automatic DHE

    Node.js has so far only supported user-defined DHE parameters and even
    recommended generating custom parameters. This change lets users set the
    dhparam option to 'auto' instead, in which case DHE parameters of
    sufficient strength are selected automatically (from a small set of
    well-known parameters). This has been recommended by OpenSSL for quite a
    while, and it makes it much easier for Node.js TLS servers to properly
    support DHE-based perfect forward secrecy.
    
    This also updates the documentation to prioritize ECDHE over DHE, mostly
    because the former tends to be more efficient and is enabled by default.
    
    PR-URL: #46978
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bb9b1c6 View commit details
    Browse the repository at this point in the history
  104. doc: amend support tier qualifier

    Amend Tier 3 category definition to remove a
    tentative clause and introduce a more concrete one.
    
    Refs: #42802
    PR-URL: #42805
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    gireeshpunathil authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    94882f5 View commit details
    Browse the repository at this point in the history
  105. debugger: improve validations and documents for watch and unwatch

    - debugger: add string validation for watch(expr)
    - debugger: add help document for watch(index)
    - test: add test for watch(index) command
    - doc: add information on unwatch(index) option
    
    PR-URL: #46947
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Dailyscat authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2b7eb56 View commit details
    Browse the repository at this point in the history
  106. benchmark: add a benchmark for URLSearchParams creation and toString()

    Refs: nodejs/performance#56
    PR-URL: #46810
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    debadree25 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7cfd31a View commit details
    Browse the repository at this point in the history
  107. doc: fix typo in test.md

    PR-URL: #47053
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    vhiairrassary authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    89f31a1 View commit details
    Browse the repository at this point in the history
  108. test: fix flakyness in test-runner reporter test

    PR-URL: #45930
    Fixes: #45929
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c972612 View commit details
    Browse the repository at this point in the history
  109. test_runner: flatten TAP output when running using --test

    PR-URL: #46440
    Fixes: #45833
    Refs: #45833
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3a1a7fa View commit details
    Browse the repository at this point in the history
  110. test_runner: emit test-only diagnostic warning

    PR-URL: #46540
    Fixes: #46448
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richiemccoll authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ffa86f7 View commit details
    Browse the repository at this point in the history
  111. test_runner: bootstrap reporters before running tests

    PR-URL: #46737
    Fixes: #46747
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6d32a16 View commit details
    Browse the repository at this point in the history
  112. events: add trailing commas in source files

    PR-URL: #46759
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1a23eab View commit details
    Browse the repository at this point in the history
  113. lib,src: fix a few typos in comments

    PR-URL: #46835
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    345c8c3 View commit details
    Browse the repository at this point in the history
  114. test_runner: reset count on watch mode

    PR-URL: #46577
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ecf714e View commit details
    Browse the repository at this point in the history
  115. lib: add trailing commas to all public core modules

    PR-URL: #46848
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5c7fc92 View commit details
    Browse the repository at this point in the history
  116. url: offload URLSearchParams initialization

    PR-URL: #46867
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    anonrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1fa6352 View commit details
    Browse the repository at this point in the history
  117. test_runner: fix reconstruction of errors extracted from YAML

    PR-URL: #46872
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0923cbc View commit details
    Browse the repository at this point in the history
  118. test_runner: avoid running twice tests in describe

    PR-URL: #46888
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    debc0ad View commit details
    Browse the repository at this point in the history
  119. lib: enforce use of trailing commas

    PR-URL: #46881
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    05614f8 View commit details
    Browse the repository at this point in the history
  120. test_runner: track bootstrapping process

    This commit updates the test harness and root test to track
    when bootstrapping has completed.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b832d77 View commit details
    Browse the repository at this point in the history
  121. test_runner: throw if harness is not bootstrapped

    This commit updates the test harness to re-throw uncaught errors
    if bootstrapping has not completed. This updates the existing
    logic which tried to detect a specific error code.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7960ccb View commit details
    Browse the repository at this point in the history
  122. test_runner: handle errors not bound to tests

    This commit addresses a previously untested branch of the code.
    It is possible when using the test runner that an error occurs
    outside of a test. In this case, the test runner would simply
    rethrow the error. This commit updates the logic to handle the
    error in the same fashion as other uncaughtExceptions.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    18146fc View commit details
    Browse the repository at this point in the history
  123. test_runner: default to spec reporter when on TTY environment

    PR-URL: #46969
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5e31599 View commit details
    Browse the repository at this point in the history
  124. esm: move hooks handling into separate class

    PR-URL: #45869
    Backport-PR-URL: #46511
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    GeoffreyBooth authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5eb5be8 View commit details
    Browse the repository at this point in the history
  125. esm: allow resolve to return import assertions

    PR-URL: #46153
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    GeoffreyBooth authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    18f0398 View commit details
    Browse the repository at this point in the history
  126. doc: remove remaining SSL_OP_NETSCAPE_*_BUG

    I missed these two in db81af6 because I
    went by OpenSSL's list of obsolete flags, which turned out to be
    incomplete. See openssl/openssl#20443.
    
    Refs: #46954
    Refs: openssl/openssl#20443
    PR-URL: #47066
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c310a32 View commit details
    Browse the repository at this point in the history
  127. src: use std::array for passing argv in node::url

    Implements a review suggestion from 72e971e.
    
    Refs: #47001 (comment)
    PR-URL: #47035
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ed31316 View commit details
    Browse the repository at this point in the history
  128. deps: update undici to 5.21.0

    PR-URL: #47063
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    84f5a1f View commit details
    Browse the repository at this point in the history
  129. tools: add undici WPTs to daily WPT Report

    PR-URL: #46763
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    12a5618 View commit details
    Browse the repository at this point in the history
  130. tools: add daily WPT Report workflow step summary

    PR-URL: #46763
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    36c48ea View commit details
    Browse the repository at this point in the history
  131. 2023-03-14, Version 19.8.0 (Current)

    Notable changes:
    
    buffer:
      * (SEMVER-MINOR) add Buffer.copyBytesFrom(...) (James M Snell) #46500
    doc:
      * add marco-ippolito to collaborators (Marco Ippolito) #46816
    events:
      * (SEMVER-MINOR) add listener argument to listenerCount (Paolo Insogna) #46523
    lib:
      * (SEMVER-MINOR) add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
    src:
      * (SEMVER-MINOR) add `fs.openAsBlob` to support File-backed Blobs (James M Snell) #45258
    tls:
      * (SEMVER-MINOR) support automatic DHE (Tobias Nießen) #46978
    url:
      * (SEMVER-MINOR) implement URLSearchParams size getter (James M Snell) #46308
    wasi:
      * (SEMVER-MINOR) add support for version when creating WASI (Michael Dawson) #46469
    worker:
      * (SEMVER-MINOR) add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832
    
    PR-URL: #47087
    targos committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4221dce View commit details
    Browse the repository at this point in the history