Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission: fix some vulnerabilities in fs #47091

Merged
merged 1 commit into from Mar 19, 2023
Merged

permission: fix some vulnerabilities in fs #47091

merged 1 commit into from Mar 19, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 14, 2023 •
edited

Without this patch, any restrictions imposed by the permission model can be easily bypassed, granting full read and write access to any file. On Windows, this could even be used to delete files that are supposed to be write-protected.

This likely also fixes a separate bug in fsPromises.open(), which currently incorrectly requires read permissions even for write-only access. (Unless that was somehow intentional?)

I'm not very confident in my understanding of the permission model. Please review carefully.

Fixes: #47090

@tniessen tniessen added fs Issues and PRs related to the fs subsystem / file system. security Issues and PRs related to security. labels Mar 14, 2023
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 14, 2023
@tniessen tniessen mentioned this pull request Mar 14, 2023
Closed
@tniessen tniessen requested a review from RafaelGSS March 14, 2023 20:44
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50382/

RafaelGSS
RafaelGSS reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I wasn't aware of write_as_side_effects. That's indeed bizarre.

src/node_file.cc Outdated Show resolved Hide resolved
src/node_file.cc Outdated Show resolved Hide resolved
test/parallel/test-permission-deny-fs-read.js Show resolved Hide resolved
RafaelGSS
RafaelGSS approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2023
@RafaelGSS RafaelGSS mentioned this pull request Mar 15, 2023
Merged
@tniessen
permission: fix some vulnerabilities in fs
233eb62 
Without this patch, any restrictions imposed by the permission model can
be easily bypassed, granting full read and write access to any file. On
Windows, this could even be used to delete files that are supposed to be
write-protected.

Fixes: nodejs#47090
@tniessen tniessen force-pushed the permission-fix-some-fatal-flaws-in-fs-open branch from c291faa to 233eb62 Compare March 15, 2023 19:05
@tniessen
Copy link
Member Author

I changed the implementation to follow V8 conventions as suggested by @targos and @addaleax. The diff is in c291faa.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen
Copy link
Member Author

Both Jenkins CI runs failed on Windows due to test-http-max-sockets, which also failed in #47108, so it seems unrelated.

@github-actions github-actions bot mentioned this pull request Mar 16, 2023
Open
22 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen mentioned this pull request Mar 16, 2023
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Open
19 tasks
@tniessen
Copy link
Member Author

It might be good to get more eyes on this, perhaps from @nodejs/libuv since especially the behavior on Windows depends more on how libuv translates flags than on Windows itself.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Mar 18, 2023
Open
23 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Mar 19, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50454/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit aa30e16 into nodejs:main Mar 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in aa30e16

This was referenced Mar 20, 2023
Open
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@RafaelGSS RafaelGSS added backport-blocked-v16.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. backport-blocked-v16.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Apr 3, 2023
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@targos targos targos left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@Trott Trott Trott approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model security Issues and PRs related to security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission logic in fs.open(), fs.openSync(), and fsPromises.open() can easily be bypassed
7 participants
@tniessen @nodejs-github-bot @Trott @addaleax @targos @RafaelGSS @marco-ippolito