Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-permission-deny-fs-wildcard (win32) #47095

Merged
merged 1 commit into from Mar 15, 2023
Merged

test: fix test-permission-deny-fs-wildcard (win32) #47095

merged 1 commit into from Mar 15, 2023

Conversation

tniessen
Copy link
Member

The test fails on Windows when the working directory is not on a 'C:' drive. For example, it always fails during the coverage-windows GitHub action, which runs tests on drive 'D:'.

Fixes: #47093

@tniessen
test: fix test-permission-deny-fs-wildcard (win32)
0e42c4c 
The test fails on Windows when the working directory is not on a 'C:'
drive. For example, it always fails during the coverage-windows GitHub
action, which runs tests on drive 'D:'.

Fixes: nodejs#47093
@tniessen tniessen requested a review from RafaelGSS March 14, 2023 19:46
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 14, 2023
RafaelGSS
RafaelGSS approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@RafaelGSS
Copy link
Member

Does it need fast-track?

@tniessen
Copy link
Member Author

Does it need fast-track?

I don't think that's strictly necessary; while the test fails during coverage-windows, the coverage jobs seem to ignore test outcomes, and Jenkins uses the C: drive for tests, so it's not blocking anything :)

@richardlau richardlau mentioned this pull request Mar 14, 2023
Merged
@richardlau
Copy link
Member

Does it need fast-track?

I don't think that's strictly necessary; while the test fails during coverage-windows, the coverage jobs seem to ignore test outcomes, and Jenkins uses the C: drive for tests, so it's not blocking anything :)

Not sure if this is the cause of this test failing on the Windows on arm64 CI: #47020

@tniessen tniessen added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 14, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen
Copy link
Member Author

@richardlau I don't know either, but I'll propose fast-tracking and we'll see.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50381/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1cfe058 into nodejs:main Mar 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1cfe058

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@RafaelGSS RafaelGSS added backport-blocked-v16.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. backport-blocked-v16.x labels Apr 3, 2023
@RafaelGSS RafaelGSS added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v19.x labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@MoLow MoLow MoLow approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-permission-deny-fs-wildcard always fails during coverage-windows GitHub action
9 participants
@tniessen @RafaelGSS @richardlau @nodejs-github-bot @lpinca @anonrig @cjihrig @MoLow @targos