doc: indicate that name is no longer an optional argument
#47102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
danielroe
changed the title
name is no longer an optional argumentname is no longer an optional argument
debadree25
approved these changes
Mar 15, 2023
targos
added
dont-land-on-v14.x
dont-land-on-v18.x
legendecas
approved these changes
Mar 15, 2023
debadree25
added
the
author ready
anonrig
approved these changes
Mar 15, 2023
anonrig
added
the
commit-queue
cjihrig
approved these changes
Mar 15, 2023
lpinca
approved these changes
Mar 15, 2023
HarshithaKP
approved these changes
Mar 16, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7deb09c |
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
PR-URL: #47102 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This was referenced Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #47097
This updates the documentation around
performance.mark()to indicate that the name argument is not optional, and that this change was made in Node 19.0.0.