Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: bootstrap prepare stack trace callback in shadow realm #47107

Merged
merged 1 commit into from Apr 4, 2023
Merged

src: bootstrap prepare stack trace callback in shadow realm #47107

merged 1 commit into from Apr 4, 2023

Conversation

legendecas
Copy link
Member

Bootstrap per-realm callbacks like prepare_stack_trace_callback in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

@legendecas legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Mar 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 15, 2023 •
edited by legendecas

Review requested:

  • @nodejs/startup
  • @nodejs/realm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 15, 2023
joyeecheung
joyeecheung reviewed Mar 15, 2023
View reviewed changes
lib/internal/bootstrap/realm.js Outdated Show resolved Hide resolved
test/parallel/test-shadow-realm-prepare-stack-trace.js Outdated Show resolved Hide resolved
src/api/environment.cc Outdated Show resolved Hide resolved
@legendecas legendecas force-pushed the shadow-realm/prepare-stack branch 2 times, most recently from 99977c5 to 86fd9e6 Compare March 20, 2023 11:39
mcollina
mcollina approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50683/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50695/

@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Open
34 tasks
cjihrig
cjihrig approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found myself needing this. LGTM once initializeWASI() is removed from pre_execution.js.

@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Open
38 tasks
@legendecas
src: bootstrap prepare stack trace callback in shadow realm
571dadd 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.
@legendecas
Copy link
Member Author

Rebased and removed initializeWASI() changes.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50813/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50822/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50829/

@github-actions github-actions bot mentioned this pull request Apr 3, 2023
Open
28 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50840/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50842/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50845/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50852/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50865/

@legendecas
Copy link
Member Author

CI is green. @nodejs/realm would you mind taking a look again with the rebase? thanks!

@github-actions github-actions bot mentioned this pull request Apr 4, 2023
Open
29 tasks
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3a014dc into nodejs:main Apr 4, 2023
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3a014dc

@legendecas legendecas deleted the shadow-realm/prepare-stack branch April 4, 2023 02:04
@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Open
26 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@legendecas @RafaelGSS
src: bootstrap prepare stack trace callback in shadow realm
53b990c 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@legendecas @RafaelGSS
src: bootstrap prepare stack trace callback in shadow realm
122c7ff 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@legendecas @RafaelGSS
src: bootstrap prepare stack trace callback in shadow realm
21832b5 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS
Copy link
Member

Hi @legendecas! I had to drop #46809 and this PR isn't landing cleanly on v19.x-staging. Can you please create a manual backport? If it strictly depends on #46809 feel free to change the label to backport-blocked-v19.x.

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@legendecas @RafaelGSS
src: bootstrap prepare stack trace callback in shadow realm
698508a 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jun 12, 2023
targos pushed a commit that referenced this pull request Nov 10, 2023
@legendecas @targos
src: bootstrap prepare stack trace callback in shadow realm
d35f870 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: bootstrap prepare stack trace callback in shadow realm
110bd4b 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: bootstrap prepare stack trace callback in shadow realm
bf56be1 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. realm Issues and PRs related to the ShadowRealm API and node::Realm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@legendecas @nodejs-github-bot @RafaelGSS @mcollina @jasnell @anonrig @cjihrig @joyeecheung @danielleadams