Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.3 #47251

Closed
wants to merge 8 commits into from
Closed

deps: update V8 to 11.3 #47251

wants to merge 8 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 25, 2023 •
edited

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Mar 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 25, 2023
@targos targos mentioned this pull request Mar 25, 2023
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@miladfarca

This comment was marked as resolved.

Sign in to view
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@miladfarca

This comment was marked as resolved.

Sign in to view
@targos targos mentioned this pull request Mar 29, 2023
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 28, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
d458018 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 29, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
c97fc85 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 30, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
9b97d9d 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 1, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
0f2f98e 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 2, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
24c2afb 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 3, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
576d944 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 4, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
62f4595 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 5, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
824d43c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 6, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
05bde80 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 7, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
8cbe6df 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 8, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
3ea744a 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 9, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
d3a595d 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request May 9, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
52b78e2 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request May 9, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
aaa0795 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 9, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
3127ac8 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 10, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
eec1268 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request May 11, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
d94b940 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 11, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
77afa00 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 12, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
20afe0a 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 13, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
7c91814 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 14, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
53c6353 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 20, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
86add58 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 21, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
0dad294 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request May 21, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
6a2e213 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 22, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
45ee8d6 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request May 22, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
4a5a02c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 23, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
770964c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 24, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
6583d57 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 25, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
309a153 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request May 26, 2024
@targos @nodejs-github-bot
deps: always define V8_EXPORT_PRIVATE as no-op
5f9748c 
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs/node#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@targos @nodejs-github-bot @miladfarca @panva @anonrig @gengjiawen @richardlau @RafaelGSS