tools: update codecov branch #47285

Trott · 2023-03-28T18:51:43Z

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue.

github-actions · 2023-03-28T18:52:20Z

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott · 2023-03-28T19:13:30Z

I hope we don't have a problem where this doesn't work because it's not on the old default branch, but I guess we can cross that bridge/issue when we get to it.

mhdawson

LGTM

tniessen · 2023-03-28T22:36:01Z

I hope we don't have a problem where this doesn't work because it's not on the old default branch, but I guess we can cross that bridge/issue when we get to it.

statsmodels/statsmodels#7424 contains a screenshot showing a configuration option in the codecov UI. (codecov appears to have picked up your branch (nodejs/node/tree/codecov) and shows it just like main or any other branch, so your suspicion might be correct and changing it might not have any effect.)

Trott · 2023-03-29T01:05:05Z

I hope we don't have a problem where this doesn't work because it's not on the old default branch, but I guess we can cross that bridge/issue when we get to it.

statsmodels/statsmodels#7424 contains a screenshot showing a configuration option in the codecov UI. (codecov appears to have picked up your branch (nodejs/node/tree/codecov) and shows it just like main or any other branch, so your suspicion might be correct and changing it might not have any effect.)

Alas, I don't have access to that settings page for Node.js.

Since the old branch redirects to the new one in the GitHub interface, I'm slightly hopeful, but only slightly, that this will work.

nodejs-github-bot · 2023-03-29T01:09:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/47285
✔  Done loading data for nodejs/node/pull/47285
----------------------------------- PR info ------------------------------------
Title      tools: update codecov branch (#47285)
Author     Rich Trott  (@Trott)
Branch     Trott:codecov -> nodejs:main
Labels     fast-track
Commits    1
 - tools: update codecov branch
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/47285
Reviewed-By: Richard Lau 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47285
Reviewed-By: Richard Lau 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Mar 2023 18:51:43 GMT
   ✔  Approvals: 5
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361728795
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361734226
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361740131
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361766478
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47285#pullrequestreview-1362075227
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4549058299

Trott · 2023-03-29T01:54:46Z

Am I wrong or does something seem to be happening where node-core-utils now always thinks GitHub CI has failed?

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue. PR-URL: nodejs#47285 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Trott · 2023-03-29T02:06:36Z

Landed in 786a718

Trott · 2023-03-29T05:08:25Z

I've opened a support ticket with Codecov.io to try to get the default branch issue resolved.

targos · 2023-03-29T06:00:21Z

I think we need to add the Codecov GitHub app to this repo so they can check who has the admin permissions?

tniessen · 2023-03-29T11:47:29Z

I was able to change the default branch through the codecov UI after someone enabled the GitHub app.

targos · 2023-03-29T16:00:33Z

Am I wrong or does something seem to be happening where node-core-utils now always thinks GitHub CI has failed?

I added some logs in ncu and found the following:

Error is from this line.

Context:

[
  {
    __typename: 'StatusContext',
    context: 'codecov/project',
    description: '89.48% (-0.03%) compared to 09a4bb1',
    targetUrl: 'https://codecov.io/gh/nodejs/node/pull/47285'
  },
  {
    __typename: 'StatusContext',
    context: 'codecov/patch',
    description: 'Coverage not affected when comparing 09a4bb1...786a718',
    targetUrl: 'https://codecov.io/gh/nodejs/node/pull/47285'
  }
]

targos · 2023-03-29T16:02:07Z

If you scroll down, the failing check is actually visible in the GitHub UI:

Trott · 2023-03-29T16:28:51Z

I was able to change the default branch through the codecov UI after someone enabled the GitHub app.

I enabled it to test if it would give me admin access and it didn't. But I only removed access again just now. Sorry for not communicating this. (I...uh....guess I should have opened something in nodejs/admin but that seemed overkill. Bad Trott? Do better?)

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: nodejs#47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: #47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: #47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue. PR-URL: #47285 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: #47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: #47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue. PR-URL: #47285 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: #47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: #47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue. PR-URL: #47285 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: #47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: #47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Codecov is still using the old default branch. Update it to "main", the current default branch. I'm not sure why it's not picking it up automatically or if there is a way to ask it to refresh, but setting it in codecov.yml should resolve the issue. PR-URL: #47285 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: #47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: #47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We don't want (yet?) to consider coverage as a requirement for landing a pull request. Refs: nodejs#47285 (comment) Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status PR-URL: nodejs#47306 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott marked this pull request as ready for review March 28, 2023 18:51

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 28, 2023

richardlau approved these changes Mar 28, 2023

View reviewed changes

MoLow approved these changes Mar 28, 2023

View reviewed changes

tniessen approved these changes Mar 28, 2023

View reviewed changes

mhdawson approved these changes Mar 28, 2023

View reviewed changes

anonrig approved these changes Mar 28, 2023

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 29, 2023

Trott force-pushed the codecov branch from d3ad6d3 to 786a718 Compare March 29, 2023 02:06

Trott merged commit 786a718 into nodejs:main Mar 29, 2023
16 checks passed

Trott deleted the codecov branch March 29, 2023 02:06

targos mentioned this pull request Mar 30, 2023

tools: disable Codecov commit statuses #47306

Merged

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

RafaelGSS mentioned this pull request Apr 6, 2023

v19.9.0 proposal #47441

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update codecov branch #47285

tools: update codecov branch #47285

Trott commented Mar 28, 2023

github-actions bot commented Mar 28, 2023

Trott commented Mar 28, 2023

mhdawson left a comment

tniessen commented Mar 28, 2023

Trott commented Mar 29, 2023

nodejs-github-bot commented Mar 29, 2023

Trott commented Mar 29, 2023 •

edited

Trott commented Mar 29, 2023

Trott commented Mar 29, 2023

targos commented Mar 29, 2023

tniessen commented Mar 29, 2023

targos commented Mar 29, 2023

targos commented Mar 29, 2023

Trott commented Mar 29, 2023

tools: update codecov branch #47285

tools: update codecov branch #47285

Conversation

Trott commented Mar 28, 2023

github-actions bot commented Mar 28, 2023

Trott commented Mar 28, 2023

mhdawson left a comment

Choose a reason for hiding this comment

tniessen commented Mar 28, 2023

Trott commented Mar 29, 2023

nodejs-github-bot commented Mar 29, 2023

Trott commented Mar 29, 2023 • edited

Trott commented Mar 29, 2023

Trott commented Mar 29, 2023

targos commented Mar 29, 2023

tniessen commented Mar 29, 2023

targos commented Mar 29, 2023

targos commented Mar 29, 2023

Trott commented Mar 29, 2023

Trott commented Mar 29, 2023 •

edited