Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix typo in nghttp2 path #47330

Merged
merged 1 commit into from Mar 31, 2023
Merged

tools: fix typo in nghttp2 path #47330

merged 1 commit into from Mar 31, 2023

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Mar 31, 2023 •
edited

Refs: #47326
Mistake in update nghttp2 path

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 31, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2023
@debadree25
Copy link
Member

Think this can be fast-tracked probably adding the fast-track label

@debadree25 debadree25 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 31, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @debadree25. Please 👍 to approve.

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit e022fb2 into nodejs:main Mar 31, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e022fb2

@targos targos mentioned this pull request Mar 31, 2023
Closed
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@marco-ippolito @RafaelGSS
tools: fix typo in nghttp2 path
0b24cd5 
PR-URL: #47330
Refs: #47326
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@marco-ippolito @RafaelGSS
tools: fix typo in nghttp2 path
33730a6 
PR-URL: #47330
Refs: #47326
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@marco-ippolito @RafaelGSS
tools: fix typo in nghttp2 path
3b77ebe 
PR-URL: #47330
Refs: #47326
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@marco-ippolito @RafaelGSS
tools: fix typo in nghttp2 path
83791e5 
PR-URL: #47330
Refs: #47326
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: fix typo in nghttp2 path
d324c15 
PR-URL: #47330
Refs: #47326
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marco-ippolito @nodejs-github-bot @debadree25 @RafaelGSS