Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] WebCryptoAPI fixes #47336

Closed
wants to merge 13 commits into from
Closed

[v16.x backport] WebCryptoAPI fixes #47336

wants to merge 13 commits into from

Commits on Mar 31, 2023

  1. crypto: add CryptoKey Symbol.toStringTag 

    closes nodejs#45987

PR-URL: nodejs#46042
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    bc17568 View commit details
    Browse the repository at this point in the history

  2. crypto: add KeyObject Symbol.toStringTag 

    PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    cca5940 View commit details
    Browse the repository at this point in the history

  3. crypto: handle more webcrypto errors with OperationError 

    PR-URL: nodejs#45320
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    c7c5011 View commit details
    Browse the repository at this point in the history

  4. test: mock structuredClone for WebCryptoAPI WPTs

    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    5b9738a View commit details
    Browse the repository at this point in the history

  5. crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey 

    PR-URL: nodejs#44917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    ae600b9 View commit details
    Browse the repository at this point in the history

  6. crypto: ensure "x" is present when importing private CFRG webcrypto keys 

    PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    252839a View commit details
    Browse the repository at this point in the history

  7. crypto: fix X25519 and X448 webcrypto public CryptoKey usages 

    PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    a321238 View commit details
    Browse the repository at this point in the history

  8. crypto: use DataError for webcrypto keyData import failures 

    PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    b72552c View commit details
    Browse the repository at this point in the history

  9. crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair 

    PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    adca91a View commit details
    Browse the repository at this point in the history

  10. crypto: fix ECDH webcrypto public CryptoKey usages 

    PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed Mar 31, 2023
    Copy the full SHA
    8570ffa View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. crypto: use WebIDL converters in WebCryptoAPI 

    WebCryptoAPI functions' arguments are now coersed and validated as per
their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of
Web Crypto API.

PR-URL: nodejs#46067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed May 15, 2023
    Copy the full SHA
    d50a7dc View commit details
    Browse the repository at this point in the history

  2. crypto: re-add padding for AES-KW wrapped JWKs 

    PR-URL: nodejs#46563
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed May 15, 2023
    Copy the full SHA
    588a166 View commit details
    Browse the repository at this point in the history

  3. crypto: fix webcrypto private/secret import with empty usages 

    Refs: nodejs#47864
PR-URL: nodejs#47877
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#47336
    @panva
    panva committed May 15, 2023
    Copy the full SHA
    ca5b942 View commit details
    Browse the repository at this point in the history