Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verify tracePromise does not do runStores #47349

Merged
merged 2 commits into from Apr 3, 2023
Merged

test: verify tracePromise does not do runStores #47349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1ec5c
test: verify tracePromise does not do runStores
Qard Mar 31, 2023
e9a2667
Update test/parallel/test-diagnostics-channel-tracing-channel-promise…
Qard Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 11 additions & 4 deletions test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js
View file
Open in desktop
Expand Up @@ -9,16 +9,23 @@ const assert = require('assert');
const channel = dc.tracingChannel('test');
const store = new AsyncLocalStorage();

const context = { foo: 'bar' };
const firstContext = { foo: 'bar' };
const secondContext = { baz: 'buz' };

channel.start.bindStore(store, common.mustCall(() => {
return context;
return firstContext;
}));

channel.asyncStart.bindStore(store, common.mustNotCall(() => {
return secondContext;
}));

assert.strictEqual(store.getStore(), undefined);
channel.tracePromise(common.mustCall(async () => {
assert.deepStrictEqual(store.getStore(), context);
assert.deepStrictEqual(store.getStore(), firstContext);
await setTimeout(1);
assert.deepStrictEqual(store.getStore(), context);
// Should _not_ switch to second context as promises don't have an "after"
// point at which to do a runStores.
assert.deepStrictEqual(store.getStore(), firstContext);
}));
assert.strictEqual(store.getStore(), undefined);