Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: lower URL.canParse runs #47351

Closed
wants to merge 1 commit into from
Closed

benchmark: lower URL.canParse runs #47351

wants to merge 1 commit into from

Conversation

KhafraDev
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. url Issues and PRs related to the legacy built-in url module. labels Mar 31, 2023
@anonrig anonrig added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig
Copy link
Member

anonrig commented Mar 31, 2023

Cancelled Jenkins jobs since it's not required. We can merge this when the Github CI is green.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50771/

@anonrig
Copy link
Member

anonrig commented Mar 31, 2023

Landed on a346b97

@anonrig anonrig closed this Mar 31, 2023
@KhafraDev KhafraDev deleted the canparse-lower-benchmark-n branch March 31, 2023 23:17
@richardlau
Copy link
Member

Landed on a346b97

@anonrig This commit appears to be missing metadata.

Trott pushed a commit that referenced this pull request Apr 1, 2023
@KhafraDev @Trott
benchmark: lower URL.canParse runs
39a08ee 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Apr 1, 2023

Landed on a346b97

@anonrig This commit appears to be missing metadata.

I ran git node metadata 47351, pasted the resulting metadata into git amend, ran core-validate-commit to make sure all was well, and force-pushed to fix.

@anonrig
Copy link
Member

anonrig commented Apr 1, 2023

Thank you @Trott and @richardlau

This was referenced Apr 2, 2023
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
1df8970 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
97eb796 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
8a8a40c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
48f6a67 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
6a4076a 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@KhafraDev @danielleadams
benchmark: lower URL.canParse runs
a72780e 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow
Copy link
Member

MoLow commented Jul 6, 2023

@danielleadams this was accidentally pushed to v18.x-staging - a72780e but is blocked by #47179

@MoLow MoLow added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 6, 2023
Merged
targos pushed a commit that referenced this pull request Nov 10, 2023
@KhafraDev @targos
benchmark: lower URL.canParse runs
3d7734c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
benchmark: lower URL.canParse runs
5c6a735 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
benchmark: lower URL.canParse runs
f69376e 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@KhafraDev @nodejs-github-bot @anonrig @richardlau @Trott @MoLow @Qard @jasnell