Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: do not expand process.argv[1] for snapshot entry points #47466

Merged
merged 1 commit into from
Apr 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/v8/startup_snapshot.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ function setDeserializeMainFunction(callback, data) {

// This should be in sync with run_main_module.js until we make that
// a built-in main function.
prepareMainThreadExecution(true);
// TODO(joyeecheung): make a copy of argv[0] and insert it as argv[1].
prepareMainThreadExecution(false);
markBootstrapComplete();
callback(data);
});
Expand Down
58 changes: 58 additions & 0 deletions test/parallel/test-snapshot-argv1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
'use strict';

// This tests snapshot JS API using the example in the docs.

require('../common');
const assert = require('assert');
const { spawnSync } = require('child_process');
const tmpdir = require('../common/tmpdir');
const path = require('path');
const fs = require('fs');

tmpdir.refresh();
const blobPath = path.join(tmpdir.path, 'snapshot.blob');
const code = `
require('v8').startupSnapshot.setDeserializeMainFunction(() => {
console.log(JSON.stringify(process.argv));
});
`;
{
fs.writeFileSync(path.join(tmpdir.path, 'entry.js'), code, 'utf8');
const child = spawnSync(process.execPath, [
'--snapshot-blob',
blobPath,
'--build-snapshot',
'entry.js',
], {
cwd: tmpdir.path
});
if (child.status !== 0) {
console.log(child.stderr.toString());
console.log(child.stdout.toString());
assert.strictEqual(child.status, 0);
}
const stats = fs.statSync(path.join(tmpdir.path, 'snapshot.blob'));
assert(stats.isFile());
}

{
const child = spawnSync(process.execPath, [
'--snapshot-blob',
blobPath,
'argv1',
'argv2',
], {
cwd: tmpdir.path,
env: {
...process.env,
}
});

const stdout = JSON.parse(child.stdout.toString().trim());
assert.deepStrictEqual(stdout, [
process.execPath,
'argv1',
'argv2',
]);
assert.strictEqual(child.status, 0);
}