Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.16.0 release proposal #47502

Merged
merged 254 commits into from Apr 13, 2023
Merged

v18.16.0 release proposal #47502

merged 254 commits into from Apr 13, 2023
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Apr 3, 2023

  1. test: add trailing commas in test/known_issues

    PR-URL: #46408
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9bb0852 View commit details
    Browse the repository at this point in the history
  2. doc: update threat model based on discussions

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46373
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    mhdawson authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f088ce2 View commit details
    Browse the repository at this point in the history
  3. async_hooks: remove experimental onPropagate option

    The `onPropagate` option for `AsyncLocalStorage` is problematic for a
    couple of reasons:
    
    1. It is not expected to be forwards compatible in any way with the
       upcoming TC-39 `AsyncContext` proposal.
    2. It introduces a non-trivial O(n) cost invoking a JavaScript callback
       for *every* AsyncResource that is created, including every Promise.
    
    While it is still experimental, I recommend removing it while we can
    revisit the fundamental use cases in light of the coming `AsyncContext`
    proposal.
    
    Refs: #46374
    PR-URL: #46386
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    jasnell authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b1bde69 View commit details
    Browse the repository at this point in the history
  4. benchmark: add trailing commas in benchmark/fs

    PR-URL: #46426
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f969cc3 View commit details
    Browse the repository at this point in the history
  5. test: make more crypto tests work with BoringSSL

    PR-URL: #46429
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    codebytere authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    534562f View commit details
    Browse the repository at this point in the history
  6. benchmark: add trailing commas in benchmark/async_hooks

    PR-URL: #46424
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f006b2f View commit details
    Browse the repository at this point in the history
  7. doc: add note about major release rotation

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #46436
    Fixes: nodejs/Release#765
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    RafaelGSS authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    4165cf3 View commit details
    Browse the repository at this point in the history
  8. stream: dont access Object.prototype.type during TransformStream init

    Fixes: #46355
    PR-URL: #46389
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    406ff32 View commit details
    Browse the repository at this point in the history
  9. doc: fix -C flag usage

    ref
    40eb3b79f1
    
    PR-URL: #46388
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sxzz authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    de7f618 View commit details
    Browse the repository at this point in the history
  10. stream: add suport for abort signal in finished() for webstreams

    Refs: #46205
    PR-URL: #46403
    Refs: #37354
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    91a550e View commit details
    Browse the repository at this point in the history
  11. stream: add pipeline() for webstreams

    Refs: #39316
    PR-URL: #46307
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6c454af View commit details
    Browse the repository at this point in the history
  12. tools: update ESLint custom rules to not use the deprecated format

    Refs: https://eslint.org/docs/latest/extend/custom-rules-deprecated
    PR-URL: #46460
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    728f968 View commit details
    Browse the repository at this point in the history
  13. benchmark: add trailing commas in benchmark/util

    PR-URL: #46438
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    01cf87a View commit details
    Browse the repository at this point in the history
  14. benchmark: add trailing commas in benchmark/net

    PR-URL: #46439
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    bd6c828 View commit details
    Browse the repository at this point in the history
  15. benchmark: add trailing commas in benchmark/module

    PR-URL: #46461
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    26e1a81 View commit details
    Browse the repository at this point in the history
  16. doc: add deokjinkim to collaborators

    Fixes: #46329
    PR-URL: #46444
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    deokjinkim authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    4d5d6d2 View commit details
    Browse the repository at this point in the history
  17. doc: fix wrong location of requestTimeout's default value

    Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout
    PR-URL: #46423
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    deokjinkim authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    68b5cf8 View commit details
    Browse the repository at this point in the history
  18. src: allow embedder control of code generation policy

    PR-URL: #46368
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    codebytere authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    17eea18 View commit details
    Browse the repository at this point in the history
  19. src: back snapshot I/O with a std::vector sink

    PR-URL: #46463
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8dfa748 View commit details
    Browse the repository at this point in the history
  20. test: add trailing commas in test/js-native-api

    PR-URL: #46385
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b0f2415 View commit details
    Browse the repository at this point in the history
  21. src: add GetCurrentCipherName/Version to crypto_common

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a639e2a View commit details
    Browse the repository at this point in the history
  22. src: add KeyObjectHandle::HasInstance

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    92fdb24 View commit details
    Browse the repository at this point in the history
  23. src: add additional utilities to crypto::SecureContext

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3aef68d View commit details
    Browse the repository at this point in the history
  24. async_hooks: add async local storage propagation benchmarks

    Add micro-benchmarks to verify the performance degradation related to
    the number of active `AsyncLocalStorage`s.
    
    With these benchmarks, trying to improve the async context propagation
    to be an O(1) operation, which is an operation more frequent compared
    to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`.
    
    PR-URL: #46414
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    97ad72f View commit details
    Browse the repository at this point in the history
  25. vm: properly support symbols on globals

    A regression has been introduced in node 18.2.0,
    it makes the following snippet fails while it used to work in the past:
    
    ```
    const assert = require('assert');
    const vm = require('vm');
    const global = vm.runInContext('this', vm.createContext());
    const totoSymbol = Symbol.for('toto');
    Object.defineProperty(global, totoSymbol, {
      enumerable: true,
      writable: true,
      value: 4,
      configurable: true,
    });
    assert(Object.getOwnPropertySymbols(global).includes(totoSymbol));
    ```
    
    Regression introduced by: #42963.
    So I basically attempted to start understanding what it changed to make
    it fix the initial issue while not breaking the symbol related one.
    
    Fixes: #45983
    PR-URL: #46458
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    dubzzz authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b801873 View commit details
    Browse the repository at this point in the history
  26. benchmark: add trailing commas in benchmark/buffers

    PR-URL: #46473
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    057e3f5 View commit details
    Browse the repository at this point in the history
  27. benchmark: add trailing commas in benchmark/misc

    PR-URL: #46474
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1497244 View commit details
    Browse the repository at this point in the history
  28. stream: allow transfer of readable byte streams

    Updates the `ReadableStream` constructor to mark byte streams as
    transferable. When transferred, byte streams become regular streams.
    
    Refs: #39062
    Refs: https://streams.spec.whatwg.org/#rs-transfer
    PR-URL: #45955
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mrbbot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    4d81124 View commit details
    Browse the repository at this point in the history
  29. timers: cleanup no-longer relevant TODOs in timers/promises

    PR-URL: #46499
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jasnell authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9b58857 View commit details
    Browse the repository at this point in the history
  30. benchmark: add trailing commas in benchmark/process

    PR-URL: #46481
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8036583 View commit details
    Browse the repository at this point in the history
  31. url: remove unused setURLConstructor function

    PR-URL: #46485
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0493056 View commit details
    Browse the repository at this point in the history
  32. url: remove unused URL::toObject

    PR-URL: #46486
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f57e7bc View commit details
    Browse the repository at this point in the history
  33. url: remove unused URL::ToFilePath()

    PR-URL: #46487
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8f14002 View commit details
    Browse the repository at this point in the history
  34. doc: enrich test command with executable

    PR-URL: #44347
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tony-go authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f1de3f7 View commit details
    Browse the repository at this point in the history
  35. doc: update test concurrency description / default values

    PR-URL: #46457
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    richiemccoll authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2b702c9 View commit details
    Browse the repository at this point in the history
  36. src: replace icu with simdutf for char counts

    PR-URL: #46472
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    aaf04f4 View commit details
    Browse the repository at this point in the history
  37. src: use simdutf utf8 to utf16 instead of icu

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f1c7700 View commit details
    Browse the repository at this point in the history
  38. src: use string_view instead of std::string&

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b9ca302 View commit details
    Browse the repository at this point in the history
  39. src: remove unused includes from main thread

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b3b3b33 View commit details
    Browse the repository at this point in the history
  40. src: check return value of ftell()

    If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
    to the vector allocator and fread().
    
    Refs: #46463
    PR-URL: #46495
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    bc9a577 View commit details
    Browse the repository at this point in the history
  41. src: avoid leaking snapshot fp on error

    Call fclose() on the snapshot file regardless of whether reading the
    snapshot data succeeded.
    
    PR-URL: #46497
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    483cd19 View commit details
    Browse the repository at this point in the history
  42. meta: update AUTHORS

    PR-URL: #46504
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5efb829 View commit details
    Browse the repository at this point in the history
  43. src: make edge names in BaseObjects more descriptive in heap snapshots

    Previously these were named "wrapper" and "wrapped", which can be
    somewhat difficult to understand. This patch renames them to
    "javascript_to_native" and "native_to_javascript".
    
    PR-URL: #46492
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9445a0a View commit details
    Browse the repository at this point in the history
  44. tools: update lint-md-dependencies to rollup@3.13.0 vfile-reporter@7.0.5

    PR-URL: #46503
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    92e3e0e View commit details
    Browse the repository at this point in the history
  45. test: enable api-invalid-label.any.js in encoding WPTs

    PR-URL: #46506
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    panva authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    4fb2fc7 View commit details
    Browse the repository at this point in the history
  46. lib: add aborted() utility function

    Fixes: #37220
    Refs: #36607
    PR-URL: #46494
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2f79f3f View commit details
    Browse the repository at this point in the history
  47. meta: move one or more collaborators to emeritus

    PR-URL: #46513
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5ef78e5 View commit details
    Browse the repository at this point in the history
  48. http: use v8::Array::New() with a prebuilt vector

    Avoid using v8::Array::Set() which results in JS execution and is
    thus slow. Prebuild the vector in C++ land and build the
    JS array directly with that vector whereever possible.
    
    PR-URL: #46447
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3d0602c View commit details
    Browse the repository at this point in the history
  49. stream: refactor to use validateAbortSignal

    PR-URL: #46520
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    17b4e9b View commit details
    Browse the repository at this point in the history
  50. lib: tighten AbortSignal.prototype.throwIfAborted implementation

    PR-URL: #46521
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2b80d19 View commit details
    Browse the repository at this point in the history
  51. lib: predeclare Event.isTrusted prop descriptor

    It improves Event creation performance.
    
    PR-URL: #46527
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    santigimeno authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    71249a6 View commit details
    Browse the repository at this point in the history
  52. src: add fflush() to SnapshotData::ToFile()

    Refs: #46491 (comment)
    PR-URL: #46531
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9567436 View commit details
    Browse the repository at this point in the history
  53. benchmark: add trailing commas in benchmark/http2

    PR-URL: #46552
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a10c355 View commit details
    Browse the repository at this point in the history
  54. benchmark: add trailing commas in benchmark/url

    PR-URL: #46551
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a383aee View commit details
    Browse the repository at this point in the history
  55. benchmark: add trailing commas in benchmark/crypto

    PR-URL: #46553
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e0f4360 View commit details
    Browse the repository at this point in the history
  56. doc: fix test runner examples

    PR-URL: #46565
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    richiemccoll authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6126830 View commit details
    Browse the repository at this point in the history
  57. deps: copy postject-api.h and LICENSE to the deps folder

    Since `postject-api.h` gets compiled into Node.js, it makes more sense
    to put it in the `deps` directory instead of `test/fixtures`.
    
    Refs: #45038 (comment)
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #46582
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RaisinTen authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    65b877d View commit details
    Browse the repository at this point in the history
  58. benchmark: add trailing commas in benchmark/http

    PR-URL: #46609
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9b0d503 View commit details
    Browse the repository at this point in the history
  59. tools: update doc to remark-html@15.0.2 to-vfile@7.2.4

    PR-URL: #46622
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    ee81da5 View commit details
    Browse the repository at this point in the history
  60. tools: update lint-md-dependencies to rollup@3.15.0 to-vfile@7.2.4

    PR-URL: #46623
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    678b8f5 View commit details
    Browse the repository at this point in the history
  61. tools: update eslint to 8.34.0

    PR-URL: #46625
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    7eb1456 View commit details
    Browse the repository at this point in the history
  62. test: add trailing commas in test/pummel

    PR-URL: #46610
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a2b103a View commit details
    Browse the repository at this point in the history
  63. http: add note about clientError event

    PR-URL: #46584
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ShogunPanda authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    abeee99 View commit details
    Browse the repository at this point in the history
  64. doc: remove unused functions from example of streamConsumers.text

    json, blob, and buffer are imported, but these functions are not
    used for example of `streamConsumers.text`.
    
    PR-URL: #46581
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    deokjinkim authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2c0e1aa View commit details
    Browse the repository at this point in the history
  65. meta: update AUTHORS

    PR-URL: #46624
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    260ddd5 View commit details
    Browse the repository at this point in the history
  66. benchmark: add trailing commas in benchmark/path

    PR-URL: #46628
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f7c4796 View commit details
    Browse the repository at this point in the history
  67. lib: enforce use of trailing commas for functions

    PR-URL: #46629
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    36e080c View commit details
    Browse the repository at this point in the history
  68. doc: add response.strictContentLength to documentation

    PR-URL: #46627
    Refs: #44378
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3afbb92 View commit details
    Browse the repository at this point in the history
  69. lib: enforce use of trailing commas in more files

    Some part of the codebase already use trailing commas, this commit is
    adding a lint rule to ensure it stays this way.
    This commit also adds the rule for a few files that were missing only
    one or two trailing commas.
    
    PR-URL: #46655
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c410572 View commit details
    Browse the repository at this point in the history
  70. lib: delete module findPath unused params

    PR-URL: #45371
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sinkhaha authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1395e36 View commit details
    Browse the repository at this point in the history
  71. stream: add abort signal for ReadableStream and WritableStream

    Refs: #39316
    PR-URL: #46273
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c60816a View commit details
    Browse the repository at this point in the history
  72. test,crypto: update WebCryptoAPI WPT

    PR-URL: #46575
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    99bfbed View commit details
    Browse the repository at this point in the history
  73. src: remove icu usage from node_string.cc

    PR-URL: #46548
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f8d0291 View commit details
    Browse the repository at this point in the history
  74. crypto: don't assume FIPS is disabled by default

    For binaries that use --shared-openssl FIPs may be enabled
    by default by the system. Allow --force-fips and --enable-fips
    to be specified in these cases.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46532
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    effdca8 View commit details
    Browse the repository at this point in the history
  75. tools: fix bug in prefer-primordials lint rule

    PR-URL: #46659
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    665b742 View commit details
    Browse the repository at this point in the history
  76. src: allow optional Isolate termination in node::Stop()

    PR-URL: #46583
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    codebytere authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    ea411d6 View commit details
    Browse the repository at this point in the history
  77. test: cover publicExponent validation in OpenSSL

    Add a test case for public exponents that are invalid according to some
    internal OpenSSL validation logic, but which are accepted by node's own
    validation logic.
    
    PR-URL: #46632
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    tniessen authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d7b995c View commit details
    Browse the repository at this point in the history
  78. doc: move bcoe to emeriti

    So long and thanks for all the bike sheds 🚲🏚️
    
    Fixes #46682
    
    PR-URL: #46703
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    bcoe authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b9dd876 View commit details
    Browse the repository at this point in the history
  79. test: fix assertions in test-snapshot-dns-lookup*

    Due to the unfortunate nature of JavaScript, the extraneous arguments
    are silently ignored. In this case, the assertion trivially passes
    regardless of the given regular expressions.
    
    Refs: #44633
    PR-URL: #46618
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    847d740 View commit details
    Browse the repository at this point in the history
  80. lib: do not crash using workers with disabled shared array buffers

    This allows the repl to function normally while using the
    `--no-harmony-sharedarraybuffer` V8 flag.
    It also fixes using workers while using the
    `--no-harmony-atomics` V8 flag.
    
    Fixes: #39717
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    
    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    PR-URL: #41023
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    2 people authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    46a22ab View commit details
    Browse the repository at this point in the history
  81. doc: add debadree25 to collaborators

    Fixes: #46526
    PR-URL: #46716
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    debadree25 authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    7606168 View commit details
    Browse the repository at this point in the history
  82. deps: update corepack to 0.16.0

    PR-URL: #46710
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    dd97b05 View commit details
    Browse the repository at this point in the history
  83. esm: misc test refactors

    - add test specific to the event loop
    - move parallel tests into es-module folder
    - refactor fixture to add braces for if blocks
    - use 'os' instead of 'fs' as placeholder
    - spelling
    
    PR-URL: #46631
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    GeoffreyBooth authored and danielleadams committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    320a8ad View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. stream: add trailing commas in stream source files

    PR-URL: #46686
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d669f22 View commit details
    Browse the repository at this point in the history
  2. stream: add trailing commas in webstream source files

    PR-URL: #46685
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c40eec3 View commit details
    Browse the repository at this point in the history
  3. lib: add trailing commas in internal/process

    PR-URL: #46687
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    48cd712 View commit details
    Browse the repository at this point in the history
  4. build: do not disable inspector when intl is disabled

    PR-URL: #37954
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Trott authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ff07aa7 View commit details
    Browse the repository at this point in the history
  5. build: add GitHub Action for coverage with --without-intl

    There are parts of the code base that require a build without intl to be
    covered. So add a coverage job to build --without-intl.
    
    PR-URL: #37954
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Trott authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2b72a45 View commit details
    Browse the repository at this point in the history
  6. process: print versions by sort

    Co-authored-by: James M Snell <jasnell@gmail.com>
    Co-authored-by: Anna Henningsen <github@addaleax.net>
    PR-URL: #46428
    Fixes: #45630
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    3 people authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c231aae View commit details
    Browse the repository at this point in the history
  7. deps: update simdutf to 3.2.0

    PR-URL: #46621
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d5eb1df View commit details
    Browse the repository at this point in the history
  8. stream: fix pipeline callback not called on ended stream

    Fixes: #46595
    PR-URL: #46600
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    debadree25 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    247caac View commit details
    Browse the repository at this point in the history
  9. lib: add AsyncLocalStorage.bind() and .snapshot()

    PR-URL: #46387
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    flakey5 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f1b7982 View commit details
    Browse the repository at this point in the history
  10. cluster: add trailing commas in source files

    PR-URL: #46695
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d2692c6 View commit details
    Browse the repository at this point in the history
  11. fs: add trailing commas in source files

    PR-URL: #46696
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    efc2409 View commit details
    Browse the repository at this point in the history
  12. lib: add trailing commas in internal/perf

    PR-URL: #46697
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4cf3de8 View commit details
    Browse the repository at this point in the history
  13. os: improve network interface performance

    This reduces the overhead of getCIDR() to a minimum. No array is
    allocated anymore and parts are directly sliced out of the netmask
    string instead.
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46598
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    594bb9d View commit details
    Browse the repository at this point in the history
  14. test: use newish OpenSSL feature in test-tls-dhe

    According to the comment that is being replaced here, this was not
    possible with the current version of OpenSSL 1.0.2 at the time the test
    was written. New OpenSSL versions appear to always print the length of
    the temporary key.
    
    Refs: nodejs/node-v0.x-archive#8272
    PR-URL: #46708
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9311116 View commit details
    Browse the repository at this point in the history
  15. tools: update lint-md-dependencies to rollup@3.17.0

    PR-URL: #46712
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    474084e View commit details
    Browse the repository at this point in the history
  16. tools: update lint-md-dependencies to rollup@3.17.1

    PR-URL: #46712
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3714d8f View commit details
    Browse the repository at this point in the history
  17. assert: remove deprecated getFunction() usage

    The method is meant to be removed by the V8 team. It is not a
    critical functionality that is removed, therefore no alternative
    is checked for either.
    
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421
    
    Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    PR-URL: #46661
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0ddf73a View commit details
    Browse the repository at this point in the history
  18. doc: add emit to NodeEventTarget

    NodeEventTarget.emit() is not described in document. Plus, make
    type parameter of removeAllListeners as optional.
    
    Refs: #35851
    PR-URL: #46356
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    deokjinkim authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    45fccc9 View commit details
    Browse the repository at this point in the history
  19. events: add listener argument to listenerCount

    PR-URL: #46523
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    ShogunPanda authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cc6deea View commit details
    Browse the repository at this point in the history
  20. http: unify header treatment

    PR-URL: #46528
    Fixes: #46395
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    23c1e2f View commit details
    Browse the repository at this point in the history
  21. test: fix flaky test-watch-mode-files_watcher

    PR-URL: #46738
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    MoLow authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b894899 View commit details
    Browse the repository at this point in the history
  22. lib: update punycode to 2.3.0

    PR-URL: #46719
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    anonrig authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ad510d9 View commit details
    Browse the repository at this point in the history
  23. punycode: add pending deprecation

    PR-URL: #46719
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    fe318dd View commit details
    Browse the repository at this point in the history
  24. src: add SetFastMethodNoSideEffect()

    The original SetFastMethod() uses v8::SideEffectType::kHasNoSideEffect
    by default, which is different from SetMethod(). Follow the
    previous convention and add a new SetFastMethodNoSideEffect()
    instead.
    
    PR-URL: #46619
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7fb32b4 View commit details
    Browse the repository at this point in the history
  25. meta: update AUTHORS

    PR-URL: #46726
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ccaa7ca View commit details
    Browse the repository at this point in the history
  26. tools: update-nghttp2 preserve config.h

    PR-URL: #46698
    Refs: #45572
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4da3eec View commit details
    Browse the repository at this point in the history
  27. tools: update nghttp2 action

    PR-URL: #46700
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    15b0e8b View commit details
    Browse the repository at this point in the history
  28. tools: fixed path

    PR-URL: #46700
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8fd1760 View commit details
    Browse the repository at this point in the history
  29. doc: maintaining nghttp2

    PR-URL: #46539
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a384dd4 View commit details
    Browse the repository at this point in the history
  30. tools: fix regex strings in Python tools

    PR-URL: #46671
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    josusky authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f80e93d View commit details
    Browse the repository at this point in the history
  31. doc: clarify semver-minor notable changes approach

    Clarifies the current approach taken by releasers when crafting notable
    changes for releases. This approach is also in line with the
    implementation of the `git node release --prepare` tooling.
    
    PR-URL: #46592
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BethGriggs authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    55360e9 View commit details
    Browse the repository at this point in the history
  32. tools: use actions pinned by commit hash in coverage-linux

    Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
    
    PR-URL: #46294
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    gabibguti authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7349708 View commit details
    Browse the repository at this point in the history
  33. tls: add trailing commas in source files

    PR-URL: #46715
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6ff9027 View commit details
    Browse the repository at this point in the history
  34. debugger: add trailing commas in source files

    PR-URL: #46714
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    44375c6 View commit details
    Browse the repository at this point in the history
  35. build,test: add proper support for IBM i

    Python 3.9 on IBM i now properly returns "os400" for sys.platform
    instead of claiming to be AIX as it did previously. While the IBM i PASE
    environment is compatible with AIX, it is a subset and has numerous
    differences which makes it beneficial to distinguish, however this means
    that it now needs explicit support here.
    
    PR-URL: #46739
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    dmabupt authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4b25b98 View commit details
    Browse the repository at this point in the history
  36. test: remove OpenSSL 1.0.2 error message compat

    While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified
    to recognize error messages from both OpenSSL releases. Given that
    OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the
    older message patterns.
    
    Refs: #16130
    PR-URL: #46709
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    533170d View commit details
    Browse the repository at this point in the history
  37. doc: add in security steward for recent release

    - add in security steward for recent release
    - add in next set of rotation entries
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46701
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Joe Sepi <sepi@joesepi.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mhdawson authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a24350e View commit details
    Browse the repository at this point in the history
  38. deps: fix libuv for android

    Fix android build errors introduced by the upgrade to libuv 1.44.2
    
    Fixes: #46743
    Fixes: #46744
    PR-URL: #46746
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nappy authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2b439a2 View commit details
    Browse the repository at this point in the history
  39. deps: update nghttp2 to 1.52.0

    Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
    PR-URL: #46636
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    targos authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c8974d6 View commit details
    Browse the repository at this point in the history
  40. doc: include context on .toWeb() parameters

    Refs: #46347
    PR-URL: #46617
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e6db6be View commit details
    Browse the repository at this point in the history
  41. doc: add test:coverage event to custom reporter examples

    PR-URL: #46752
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    richiemccoll authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    eef3051 View commit details
    Browse the repository at this point in the history
  42. http: fix validation of "Link" header

    Updated regex for "Link" header validation to better match the
    specification in RFC 8288 section 3. Does not check for valid URI
    format but handles the rest of the header more permissively than
    before. Alternative to another outstanding PR that disables validation
    entirely.
    
    Fixes: #46453
    Refs: https://www.rfc-editor.org/rfc/rfc8288.html#section-3
    Refs: #46464
    PR-URL: #46466
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    SRHerzog authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9582c8e View commit details
    Browse the repository at this point in the history
  43. http: correctly calculate strict content length

    Fixes some logical errors related to strict content length.
    
    Also, previously Buffer.byteLength (which is slow) was run regardless of
    whether or not the len was required.
    
    PR-URL: #46601
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    ronag authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3538521 View commit details
    Browse the repository at this point in the history
  44. benchmark: fix worker startup benchmark

    It previously called spawnProcess in spawnWorker, which was
    incorrect.
    
    PR-URL: #46680
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d7d634b View commit details
    Browse the repository at this point in the history
  45. doc: add document for profiling and heap snapshot

    PR-URL: #46787
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cola119 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3dae6f2 View commit details
    Browse the repository at this point in the history
  46. doc: document how to use the tls.DEFAULT_CIPHERS

    The DEFAULT_CIPHERS already exists, this change shows how to use it.
    
    Fixes: #46462
    PR-URL: #46482
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    andreas-ibm authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7e08ca1 View commit details
    Browse the repository at this point in the history
  47. test: include strace openat test

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #46150
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3b70e7a View commit details
    Browse the repository at this point in the history
  48. node-api: add __wasm32__ guards on async works

    PR-URL: #46633
    Refs: #33597
    Refs: nodejs/node-addon-api#1283
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    331073a View commit details
    Browse the repository at this point in the history
  49. repl: add trailing commas in source files

    PR-URL: #46757
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    91fbad6 View commit details
    Browse the repository at this point in the history
  50. child_process: add trailing commas in source files

    PR-URL: #46758
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5353110 View commit details
    Browse the repository at this point in the history
  51. test: improve control flow in test-tls-dhe

    If this test fails, e.g., if the s_client output does not match the
    expectation, the previous implementation would not produce any helpful
    error messages. Rework the control flow to be more idiomatic. Avoid
    callback chaining and stream operations.
    
    Also, the TLS server 'close' event does not pass an error to the event
    handler, so remove the respective assertion.
    
    PR-URL: #46751
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    25cab7e View commit details
    Browse the repository at this point in the history
  52. tools: run format-cpp on node-api test c files

    PR-URL: #46694
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4065e5c View commit details
    Browse the repository at this point in the history
  53. test: fix test-v8-collect-gc-profile-in-worker.js

    PR-URL: #46735
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    theanarkh authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ea71a2a View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    ed2faa7 View commit details
    Browse the repository at this point in the history
  55. meta: update CODEOWNERS of url implementations

    PR-URL: #46775
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    anonrig authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    55f1cfd View commit details
    Browse the repository at this point in the history
  56. doc: add marco-ippolito to collaborators

    Fixes: #46660
    PR-URL: #46816
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8b636c3 View commit details
    Browse the repository at this point in the history
  57. url: implement URLSearchParams size getter

    Refs: whatwg/url#734
    PR-URL: #46308
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    jasnell authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1ece4a7 View commit details
    Browse the repository at this point in the history
  58. deps: upgrade npm to 9.5.1

    PR-URL: #46783
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    npm-cli-bot authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    63a62ed View commit details
    Browse the repository at this point in the history
  59. dgram: fix unhandled exception aborting a closed udp socket

    Fixes: #46750
    PR-URL: #46770
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vramana authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8646b06 View commit details
    Browse the repository at this point in the history
  60. test: remove unreachable return

    PR-URL: #46807
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jakecastelli authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bb18246 View commit details
    Browse the repository at this point in the history
  61. meta: remove unnecessary onboarding step

    While it is nice to notify the TSC about accepted nominations,
    it is not strictly necessary and I think we should streamline
    things as much as possible.
    
    PR-URL: #46793
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e53774c View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. tools: update lint-md-dependencies to rollup@3.17.2

    PR-URL: #46771
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3bf54ff View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. deps: update simdutf to 3.2.1

    PR-URL: #46800
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    61c9433 View commit details
    Browse the repository at this point in the history
  2. test: remove useless WPT init scripts

    PR-URL: #46801
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    928998d View commit details
    Browse the repository at this point in the history
  3. test: update encoding WPTs

    PR-URL: #46802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    panva authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    df14944 View commit details
    Browse the repository at this point in the history
  4. test: simplify test-tls-alert

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46805
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3644796 View commit details
    Browse the repository at this point in the history
  5. test: fix test-net-connect-reset-until-connected

    Fixes: #43446
    PR-URL: #46781
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    batrla authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    dfb566a View commit details
    Browse the repository at this point in the history
  6. tools: update lint-md-dependencies to rollup@3.17.3

    PR-URL: #46843
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    89c2e8a View commit details
    Browse the repository at this point in the history
  7. benchmark: add benchmark for EventTarget add and remove

    Refs: nodejs/performance#60
    PR-URL: #46779
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5f647fb View commit details
    Browse the repository at this point in the history
  8. lib: add trailing commas to more internal files

    PR-URL: #46811
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    31578ab View commit details
    Browse the repository at this point in the history
  9. deps: update corepack to 0.17.0

    PR-URL: #46842
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0e78fd5 View commit details
    Browse the repository at this point in the history
  10. stream: always delay construct callback by a nextTick

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    Fixes: #46765
    PR-URL: #46818
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    mcollina authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    654b747 View commit details
    Browse the repository at this point in the history
  11. tools: fix linter message when using global DOMException

    Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
    PR-URL: #46822
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fff3186 View commit details
    Browse the repository at this point in the history
  12. benchmark: split Buffer.byteLength benchmark

    PR-URL: #46616
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d4af671 View commit details
    Browse the repository at this point in the history
  13. assert: fix exception message for assert(0) on try catch block

    Fixes: #30872
    PR-URL: #46760
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    hidecology authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c742493 View commit details
    Browse the repository at this point in the history
  14. buffer: add Buffer.copyBytesFrom(...)

    Fixes: #43862
    PR-URL: #46500
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c6e722a View commit details
    Browse the repository at this point in the history
  15. lib: rename internal module declaration as internal bindings

    This is a follow-up to #45551 .
    
    Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
    to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
    As these bindings are already loaded with the function internalBinding
    in the JS land, the term "internal binding" can be straightforward to
    be adopted.
    
    PR-URL: #46663
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    okmttdhr authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    06e0dd3 View commit details
    Browse the repository at this point in the history
  16. stream: enable usage of webstreams on compose()

    Refs: #39316
    PR-URL: #46675
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    debadree25 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    dffe7d8 View commit details
    Browse the repository at this point in the history
  17. tools: create llhttp update action

    PR-URL: #46766
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    307d096 View commit details
    Browse the repository at this point in the history
  18. bootstrap: print stack trace during environment creation failure

    #45888 took the environment
    creation code out of the scope covered by the v8::TryCatch
    that we use to print early failures during environment creation.
    So e.g. when adding something that would fail in node.js, we get
    
    ```
    node:internal/options:554: Uncaught Error: Should not query options before bootstrapping is done
    ```
    
    This patch restores that by adding another v8::TryCatch for it:
    
    ```
    node:internal/options:20
        ({ options: optionsMap } = getCLIOptions());
                                   ^
    
    Error: Should not query options before bootstrapping is done
        at getCLIOptionsFromBinding (node:internal/options:20:32)
        at getOptionValue (node:internal/options:45:19)
        at node:internal/bootstrap/node:433:29
    ```
    
    PR-URL: #46533
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5202b84 View commit details
    Browse the repository at this point in the history
  19. src: fix cb scope bugs involved in termination

    Be more aggresive to clean up the async id stack,
    and ensure the cleanup when terminating.
    
    Calling SetIdle() when terminating is not harmless.
    When node terminates due to an unhandled exception,
    v8 preseves the vm state, which is JS and notifies
    node through PerIsolateMessageListener(). If node
    calls SetIdle() later, v8 complains because it
    requires the vm state to either be EXTERNEL or IDLE
    when embedder calling SetIdle().
    
    PR-URL: #45596
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    ywave620 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    03e8d82 View commit details
    Browse the repository at this point in the history
  20. doc: use destructing import

    PR-URL: #46847
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jakecastelli authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6e03499 View commit details
    Browse the repository at this point in the history
  21. doc: sort import order

    PR-URL: #46847
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jakecastelli authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    810d393 View commit details
    Browse the repository at this point in the history
  22. doc: add history info for node:test

    PR-URL: #46851
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0a983f7 View commit details
    Browse the repository at this point in the history
  23. meta: remove AUTHORS file

    The AUTHORS file does not serve any significant practical purpose and is
    a bit of a maintenance annoyance. Let's remove it.
    
    PR-URL: #46845
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    abe1488 View commit details
    Browse the repository at this point in the history
  24. tools: update eslint to 8.35.0

    PR-URL: #46854
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c0b6794 View commit details
    Browse the repository at this point in the history
  25. src: do not track BaseObjects directly in Realm

    They are referenced through the CleanupQueue which is already
    tracked. Tracking them again in Realms results in duplicates in
    the heap snapshot.
    
    PR-URL: #46470
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    88baf98 View commit details
    Browse the repository at this point in the history
  26. src: remove shadowed variable in OptionsParser

    PR-URL: #46672
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    codebytere authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b25ee52 View commit details
    Browse the repository at this point in the history
  27. test: move socket from CWD to temporary directory

    PR-URL: #46863
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    LiviaMedeiros authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b344e74 View commit details
    Browse the repository at this point in the history
  28. url: improve isURLThis detection

    PR-URL: #46866
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    anonrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4d0faf4 View commit details
    Browse the repository at this point in the history
  29. repl: fix .load infinite loop caused by shared use of lineEnding RegExp

    Since the lineEnding Regular Expression is declared on the module scope,
    recursive invocations of its `[kTtyWrite]` method share one instance of
    this Regular Expression.
    Since the state of a RegExp is managed by instance,
    alternately calling RegExpPrototypeExec with the same RegExp on
    different strings can lead to the state changing unexpectedly.
    This is the root cause of this infinite loop bug when calling .load on
    javascript files of certain shapes.
    
    PR-URL: #46742
    Fixes: #46731
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Theo-Steiner authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    09739a2 View commit details
    Browse the repository at this point in the history
  30. repl: remove lastInputPreview conditional check

    PR-URL: #46857
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    jenthone authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    34ba230 View commit details
    Browse the repository at this point in the history
  31. src: make util.h self-containted

    Before it depended on util-inl.h. Fix it by moving
    MaybeStackBuffer::AllocateSufficientStorage() into
    util-inl.h
    
    PR-URL: #46817
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    339b52f View commit details
    Browse the repository at this point in the history
  32. doc: fix stream iterator helpers examples

    PR-URL: #46897
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    benjamingr authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0254fd1 View commit details
    Browse the repository at this point in the history
  33. test: fix os-release check for Ubuntu in SEA test

    For example, my `/etc/os-release` file begins with
    
    ```
    PRETTY_NAME="Ubuntu 22.04.2 LTS"
    NAME="Ubuntu"
    VERSION_ID="22.04"
    ```
    
    so in order to match the regexp here, the `/m` flag is necessary.
    
    PR-URL: #46838
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    966d0d8 View commit details
    Browse the repository at this point in the history
  34. doc: add request to hold off publicising sec releases

    - We've often seen tweets go out early before announcement
      and other parts of the security release complete
    - Make an explicit ask that collaborators avoid doing this
      by gating on the tweet from the Node.js account
    - Releasers would still be free to tweet earlier as they know
      when the process is complete.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #46702
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    11885a7 View commit details
    Browse the repository at this point in the history
  35. deps: update simdutf to 3.2.2

    PR-URL: #46841
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    73be4f8 View commit details
    Browse the repository at this point in the history
  36. test: assume priv ports start at 1024 if it can't be changed

    An update to test/parallel/test-cluster-bind-privileged-port.js
    checks the lowest privileged port to ensure 42 is privileged
    This only works on kernels > 4.1. On older kernels, this is
    locked at 1024 so the check is not needed.
    
    Fixes: #45838
    PR-URL: #46536
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    KrayzeeKev authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3fdcf7b View commit details
    Browse the repository at this point in the history
  37. tools: refactor dep_updaters

    PR-URL: #46488
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tony-go authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    36ea9e7 View commit details
    Browse the repository at this point in the history
  38. build: fix Visual Studio installation detection for Arm64

    PR-URL: #46420
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Blackhex authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    886504f View commit details
    Browse the repository at this point in the history
  39. test: move testPath from CWD to temporary directory

    PR-URL: #46890
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    LiviaMedeiros authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    512f28f View commit details
    Browse the repository at this point in the history
  40. esm: add a runtime warning when using import assertions

    PR-URL: #46901
    Refs: #46830
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    96a39d1 View commit details
    Browse the repository at this point in the history
  41. doc: fix fs missing import

    PR-URL: #46907
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    jakecastelli authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ea7fb16 View commit details
    Browse the repository at this point in the history
  42. doc: fix links to SSL_CTX_set_options

    The old 1.0.2 docs do not exist anymore; link to the same file for
    OpenSSL 3.0 instead.
    
    PR-URL: #46953
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f49c6e6 View commit details
    Browse the repository at this point in the history
  43. doc: add release key for Juan Arboleda

    PR-URL: #46922
    Refs: nodejs/Release#829
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    juanarbol authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4e6dda5 View commit details
    Browse the repository at this point in the history
  44. test_runner: align behavior of it and test

    PR-URL: #46889
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    e52b169 View commit details
    Browse the repository at this point in the history
  45. test: simplify test-tls-ecdh-auto

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46911
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3399195 View commit details
    Browse the repository at this point in the history
  46. tools: update lint-md-dependencies to rollup@3.18.0

    PR-URL: #46935
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    77f5b69 View commit details
    Browse the repository at this point in the history
  47. doc: use number which is bigger than 1024 as port in http2

    With 80 port, user should run example with root permission.
    To avoid such situation, use 8000 or 8443 as port number
    in example of http2.
    
    PR-URL: #46938
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    deokjinkim authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ad06168 View commit details
    Browse the repository at this point in the history
  48. doc: fix port of destination server is not defined in http2

    `port` variable is used, but it's not defined in client code.
    So need to specify destination server(not proxy)'s port(8000)
    in client code.
    
    Refs: https://github.com/nodejs/node/blob/main/doc/api/http2.md#supporting-the-connect-method
    PR-URL: #46940
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    deokjinkim authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    17a25f1 View commit details
    Browse the repository at this point in the history
  49. doc: improve fs code example quality

    PR-URL: #46948
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    jakecastelli authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8907732 View commit details
    Browse the repository at this point in the history
  50. doc: fix description of TLS dhparam option

    The dhparam option is not required for perfect forward secrecy in
    general. It is only required for non-ECDHE secrecy, but ECDHE-based
    secrecy is generally preferred anyway.
    
    PR-URL: #46949
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    09c5e6a View commit details
    Browse the repository at this point in the history
  51. worker: add support for worker name in inspector and trace_events

    Fixes: #41589
    PR-URL: #46832
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    debadree25 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f7423bd View commit details
    Browse the repository at this point in the history
  52. doc: remove useless SSL_OP_* options

    These 14 options do not have any effect in any supported version of
    OpenSSL.
    
    PR-URL: #46954
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    257c5ac View commit details
    Browse the repository at this point in the history
  53. test: improve test coverage of lib/dns

    PR-URL: #46910
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    paivaandeerson authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b8cdd15 View commit details
    Browse the repository at this point in the history
  54. deps,test: update postject to 1.0.0-alpha.5

    PR-URL: #46934
    Fixes: nodejs/postject#76
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f8d4bf8 View commit details
    Browse the repository at this point in the history
  55. esm: fix import assertion warning

    Refs: #46901 (comment)
    PR-URL: #46971
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5b94e2b View commit details
    Browse the repository at this point in the history
  56. test_runner: give the root test a harness reference

    This commit replaces the 'coverage' reference inside of the Test
    class with a more generic harness reference which includes
    coverage. This will let the root test more easily track process
    level state such as code coverage, uncaughtException handlers,
    and the state of bootstrapping.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    15503ff View commit details
    Browse the repository at this point in the history
  57. test_runner: remove root tracking set

    The wasRootSetup Set in the test harness appears to be
    redundant, since the startTime field can be used interchangeably.
    This commit removes wasRootSetup.
    
    PR-URL: #46961
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3b077a6 View commit details
    Browse the repository at this point in the history
  58. http: use listenerCount when adding noop event

    PR-URL: #46769
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ShogunPanda authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    80b4e6d View commit details
    Browse the repository at this point in the history
  59. doc: fix myUrl is not defined in url

    Fixes a typo in the variable name in the URL code example in doc.
    Renames `myUrl` to `myURL` for consistency and readability.
    
    PR-URL: #46968
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    recrack authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b37d53a View commit details
    Browse the repository at this point in the history
  60. doc: fix history information for node:diagnostics_channel

    `node:diagnostics_channel` was backported to Node.js v14.17.0.
    
    PR-URL: #46984
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    tlhunter authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    43b94b0 View commit details
    Browse the repository at this point in the history
  61. typings: improve primordials typings

    PR-URL: #46970
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    78b79c0 View commit details
    Browse the repository at this point in the history
  62. doc: add missing test runner flags to man page

    --test-reporter and --test-reporter-destination were previously
    missing from the man page.
    
    PR-URL: #46982
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6a0c1d0 View commit details
    Browse the repository at this point in the history
  63. src: remove use of SSL_OP_SINGLE_DH_USE

    This option does not have any effect in any supported OpenSSL version.
    
    Refs: #46954
    PR-URL: #46955
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a4a433f View commit details
    Browse the repository at this point in the history
  64. src: remove TLSEXT_TYPE_alpn guard

    TLSEXT_TYPE_application_layer_protocol_negotiation is always defined in
    all supported OpenSSL versions. We also use this macro elsewhere without
    guards, so if it did not exist, compilation would have already failed.
    
    Besides that, it makes little sense to provide a TLS 1.3 implementation
    that does not support ALPN.
    
    PR-URL: #46956
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4652dfd View commit details
    Browse the repository at this point in the history
  65. test: simplify test-tls-ecdh-multiple

    Avoid the process 'exit' event handler and use execFile instead of
    manual stream operations.
    
    Refs: #46751
    PR-URL: #46963
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ef6c86c View commit details
    Browse the repository at this point in the history
  66. test,crypto: update WebCryptoAPI WPT

    PR-URL: #47010
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5e008e7 View commit details
    Browse the repository at this point in the history
  67. meta: add single-executable labels and code owners

    PR-URL: #47004
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c4f192b View commit details
    Browse the repository at this point in the history
  68. doc: fix typo on esm loaders example

    Fixes a small typo on the Transpiler loader example.
    
    PR-URL: #47015
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ruyadorno authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a5bf669 View commit details
    Browse the repository at this point in the history
  69. tools: automate cares update

    PR-URL: #46993
    Refs: nodejs/security-wg#828
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    marco-ippolito authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a3f272e View commit details
    Browse the repository at this point in the history
  70. test: fallback to IPv4 if IPv6 is unavailable

    openssl seems to default to use IPv6.
    This change adds a checks if IPv6 is unavailable and uses IPv4 instead.
    On the Node.js CI IBM i build system IPv6 is currently disabled.
    This change should resolve the following test case failures:
    - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_psk_client_/
    - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_securepair_client_/
    
    PR-URL: #47017
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    abmusse authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0edaf01 View commit details
    Browse the repository at this point in the history
  71. benchmark: replace table in docs with description of file tree structure

    The markdown table in `benchmark/README.md` has grown stale, no
    longer providing an overview over all existing benchmarks. As it has
    proven difficult to keep an exhaustive listing of available benchmarks
    up to date, this commit provides a description of how the directory is
    structured instead.
    
    PR-URL: #46991
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Theo-Steiner authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ff94f9f View commit details
    Browse the repository at this point in the history
  72. test: move test-tls-autoselectfamily-servername to test/internet

    And switch from `google.com` to `nodejs.org`.
    
    PR-URL: #47029
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ba340a0 View commit details
    Browse the repository at this point in the history
  73. debugger: add a command to set which lines to check for context

    PR-URL: #46812
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Dailyscat authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    51253ba View commit details
    Browse the repository at this point in the history
  74. tls: support automatic DHE

    Node.js has so far only supported user-defined DHE parameters and even
    recommended generating custom parameters. This change lets users set the
    dhparam option to 'auto' instead, in which case DHE parameters of
    sufficient strength are selected automatically (from a small set of
    well-known parameters). This has been recommended by OpenSSL for quite a
    while, and it makes it much easier for Node.js TLS servers to properly
    support DHE-based perfect forward secrecy.
    
    This also updates the documentation to prioritize ECDHE over DHE, mostly
    because the former tends to be more efficient and is enabled by default.
    
    PR-URL: #46978
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    32c527d View commit details
    Browse the repository at this point in the history
  75. doc: amend support tier qualifier

    Amend Tier 3 category definition to remove a
    tentative clause and introduce a more concrete one.
    
    Refs: #42802
    PR-URL: #42805
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    gireeshpunathil authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0e3077d View commit details
    Browse the repository at this point in the history
  76. debugger: improve validations and documents for watch and unwatch

    - debugger: add string validation for watch(expr)
    - debugger: add help document for watch(index)
    - test: add test for watch(index) command
    - doc: add information on unwatch(index) option
    
    PR-URL: #46947
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Dailyscat authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    bce37c6 View commit details
    Browse the repository at this point in the history
  77. benchmark: add a benchmark for URLSearchParams creation and toString()

    Refs: nodejs/performance#56
    PR-URL: #46810
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    debadree25 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b5db3b5 View commit details
    Browse the repository at this point in the history
  78. doc: fix typo in test.md

    PR-URL: #47053
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    vhiairrassary authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    01d8267 View commit details
    Browse the repository at this point in the history
  79. events: add trailing commas in source files

    PR-URL: #46759
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b08687f View commit details
    Browse the repository at this point in the history
  80. lib,src: fix a few typos in comments

    PR-URL: #46835
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7f9e60a View commit details
    Browse the repository at this point in the history
  81. test_runner: reset count on watch mode

    PR-URL: #46577
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MoLow authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    17fbfb2 View commit details
    Browse the repository at this point in the history
  82. lib: add trailing commas to all public core modules

    PR-URL: #46848
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0f33bb0 View commit details
    Browse the repository at this point in the history
  83. test_runner: fix reconstruction of errors extracted from YAML

    PR-URL: #46872
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    524eaf5 View commit details
    Browse the repository at this point in the history
  84. test_runner: avoid running twice tests in describe

    PR-URL: #46888
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    413493c View commit details
    Browse the repository at this point in the history
  85. lib: enforce use of trailing commas

    PR-URL: #46881
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c463f13 View commit details
    Browse the repository at this point in the history
  86. test_runner: track bootstrapping process

    This commit updates the test harness and root test to track
    when bootstrapping has completed.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ab5b318 View commit details
    Browse the repository at this point in the history
  87. test_runner: throw if harness is not bootstrapped

    This commit updates the test harness to re-throw uncaught errors
    if bootstrapping has not completed. This updates the existing
    logic which tried to detect a specific error code.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d60eef2 View commit details
    Browse the repository at this point in the history
  88. test_runner: handle errors not bound to tests

    This commit addresses a previously untested branch of the code.
    It is possible when using the test runner that an error occurs
    outside of a test. In this case, the test runner would simply
    rethrow the error. This commit updates the logic to handle the
    error in the same fashion as other uncaughtExceptions.
    
    PR-URL: #46962
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cjihrig authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    16db3ad View commit details
    Browse the repository at this point in the history
  89. test_runner: default to spec reporter when on TTY environment

    PR-URL: #46969
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8398f9f View commit details
    Browse the repository at this point in the history
  90. doc: remove remaining SSL_OP_NETSCAPE_*_BUG

    I missed these two in db81af6 because I
    went by OpenSSL's list of obsolete flags, which turned out to be
    incomplete. See openssl/openssl#20443.
    
    Refs: #46954
    Refs: openssl/openssl#20443
    PR-URL: #47066
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    e435199 View commit details
    Browse the repository at this point in the history
  91. deps: update undici to 5.21.0

    PR-URL: #47063
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    956f786 View commit details
    Browse the repository at this point in the history
  92. src: add initial support for single executable applications

    Compile a JavaScript file into a single executable application:
    
    ```console
    $ echo 'console.log(`Hello, ${process.argv[2]}!`);' > hello.js
    
    $ cp $(command -v node) hello
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2 \
        --macho-segment-name NODE_JS
    
    $ ./hello world
    Hello, world!
    ```
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #45038
    Backport-PR-URL: #47495
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    RaisinTen authored and danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8ea8354 View commit details
    Browse the repository at this point in the history
  93. lib: fix trailing commas and leftover function from rebasing

    PR-URL: #47503
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    danielleadams committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    62cbddd View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. deps: add ada as a dependency

    PR-URL: #46410
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0bc4c17 View commit details
    Browse the repository at this point in the history
  2. url: replace url-parser with ada

    PR-URL: #46410
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e926354 View commit details
    Browse the repository at this point in the history
  3. tools: fix update-ada script

    PR-URL: #46550
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    958da45 View commit details
    Browse the repository at this point in the history
  4. deps: update ada to v1.0.1

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
    PR-URL: #46550
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    2 people authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    484c4f6 View commit details
    Browse the repository at this point in the history
  5. test: update web-platform tests for url

    PR-URL: #46547
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    972bdee View commit details
    Browse the repository at this point in the history
  6. url: fix url spec compliance issues

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
    PR-URL: #46547
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    2 people authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0c67a7a View commit details
    Browse the repository at this point in the history
  7. url: improve performance by removing host

    PR-URL: #46547
    Backport-PR-URL: #47435
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    01b6525 View commit details
    Browse the repository at this point in the history
  8. deps: update ada to 1.0.3

    PR-URL: #46784
    Backport-PR-URL: #47435
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    94f8353 View commit details
    Browse the repository at this point in the history
  9. deps: update ada to 1.0.4

    PR-URL: #46853
    Backport-PR-URL: #47435
    Fixes: #46850
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    nodejs-github-bot authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e5c4d69 View commit details
    Browse the repository at this point in the history
  10. src: use string_view for report and related code

    Use `std::string_view` for process.report code and related
    code, drop a few unnecessary `std::to_string` calls,
    and use `MaybeStackBuffer` instead of `MallocedBuffer`,
    all in order to avoid unnecessary heap allocations.
    
    PR-URL: #46723
    Backport-PR-URL: #47435
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    addaleax authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e4cd81b View commit details
    Browse the repository at this point in the history
  11. url: simplify and improve url formatting

    PR-URL: #46736
    Backport-PR-URL: #47435
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    a39dd37 View commit details
    Browse the repository at this point in the history
  12. 2023-04-12, Version 18.16.0 'Hydrogen' (LTS)

    Notable changes:
    
    Add initial support for single executable applications
    
    Compile a JavaScript file into a single executable application:
    
    ```console
    $ echo 'console.log(`Hello, ${process.argv[2]}!`);' > hello.js
    
    $ cp $(command -v node) hello
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2 \
        --macho-segment-name NODE_JS
    
    $ ./hello world
    Hello, world!
    ```
    
    Contributed by Darshan Sen in #45038
    
    Replace url parser with Ada
    
    Node.js gets a new URL parser called Ada that is compliant with the WHATWG
    URL Specification and provides more than 100% performance improvement to
    the existing implementation.
    
    Contributed by Yagiz Nizipli in #46410
    
    Other notable changes:
    
    * buffer:
      * (SEMVER-MINOR) add Buffer.copyBytesFrom(...) (James M Snell) #46500
    * doc:
      * add marco-ippolito to collaborators (Marco Ippolito) #46816
      * add debadree25 to collaborators (Debadree Chatterjee) #46716
      * add deokjinkim to collaborators (Deokjin Kim) #46444
    * events:
      * (SEMVER-MINOR) add listener argument to listenerCount (Paolo Insogna) #46523
    * lib:
      * (SEMVER-MINOR) add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
      * (SEMVER-MINOR) add aborted() utility function (Debadree Chatterjee) #46494
    * src:
      * (SEMVER-MINOR) allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
      * (SEMVER-MINOR) allow embedder control of code generation policy (Shelley Vohr) #46368
    * stream:
      * (SEMVER-MINOR) add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
    * tls:
      * (SEMVER-MINOR) support automatic DHE (Tobias Nießen) #46978
    * url:
      * (SEMVER-MINOR) implement URLSearchParams size getter (James M Snell) #46308
    * worker:
      * (SEMVER-MINOR) add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832
    
    PR-URL: #47502
    danielleadams committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    43d167a View commit details
    Browse the repository at this point in the history